Continuation of @jschuelller's 5.12.4 PR.

[mingwandroid]

Checklist

• Used a fork of the feedstock to propose changes
• Bumped the build number (if the version is unchanged)
• Reset the build number to 0 (if the version changed)
• Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
• Ensured the license file is being packaged.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[ocefpaf]

@jschueller and @mingwandroid please let me know when O should try to build these locally for the upload.

[isuruf]

Use the pkg hash here.

[mingwandroid]

For my debugging purposes I need to switch this depending on dev_nature.

[mingwandroid]

i.e {% if dev_nature != '' %} .. around it or something like that. dev_nature will not be set unless forced via the command line.

[isuruf]

I meant use the pkg hash in addition. Something like {{ PKG_HASH }}_{{ build_number }}{{ dev_nature }}

[mingwandroid]

OK, cool

[isuruf]

Remove these 2 lines

[mingwandroid]

We need these for Anaconda Distro, are they harmful?

[isuruf]

Yes, it's harmful for conda-forge as we are installing the SDK somewhere else.

[mingwandroid]

OK, I'm probably OK with aligning our location then. We do need to force 10.12 somehow though. What is the default ATM? Any clues how to force 10.12?

[isuruf]

It is set to $(xcode-select -p)/Platforms/MacOSX.platform/Developer/SDKs/MacOSX${MACOSX_DEPLOYMENT_TARGET}.sdk which wade sense when we were using system compilers.

Default is 10.9. If you set MACOSX_DEPLOYMENT_TARGET to 10.12 as you've done here in recipe/conda_build_config.yaml, the CI script will read that variable, download 10.12, extract it and automatically set CONDA_BUILD_SYSROOT. So there's no need to set CONDA_BUILD_SYSROOT in the recipe. Just MACOSX_DEPLOYMENT_TARGET would do.

[jschueller]

@isuruf, your commit fails:

cp: ../licenses/LICENSE.FDL: No such file or directory

[jschueller]

I think this one may be closed

[ccordoba12]

Sure, I think so too.