Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r-arrow v6.0.0 #43

Merged
merged 5 commits into from Nov 12, 2021
Merged

r-arrow v6.0.0 #43

merged 5 commits into from Nov 12, 2021

Conversation

gabrielmagno
Copy link
Contributor

@gabrielmagno gabrielmagno commented Nov 9, 2021

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@gabrielmagno gabrielmagno requested review from a team as code owners November 9, 2021 19:31
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@gabrielmagno
Copy link
Contributor Author

@conda-forge-admin, please rerender

@gabrielmagno gabrielmagno changed the title r-arrow v5.0.0 r-arrow v6.0.0 Nov 9, 2021
@xhochy
Copy link
Member

xhochy commented Nov 9, 2021

We'll probably have to wait for an additional hour until arrow-cpp 6.0 is available on the CDN.

@gabrielmagno
Copy link
Contributor Author

We'll probably have to wait for an additional hour until arrow-cpp 6.0 is available on the CDN.

That's right, thanks for the comment.

I was just ansious to test v6 and realized that it was not in conda-forge yet, and decided to do a PR.

I just realized that there is a bot that automatically bumps the version or this repo.

If you think it is better to let the bot do it, I can delete/close this PR.

@gabrielmagno
Copy link
Contributor Author

The Windows build failed.

I will try to fix it, but not sure if I will be able to, since I'm not familiar with the Windows building pipeline.

@gabrielmagno
Copy link
Contributor Author

The error for the Windows build is this one:

(%BUILD_PREFIX%) %SRC_DIR%\r\src>%BUILD_PREFIX%\Library\bin\clang++.exe -std=gnu++11 -ID:/bld/r-arrow_1636551521857/_h_env/lib/R/include -DNDEBUG -DNDEBUG -I%BUILD_PREFIX%\Library/include -I%BUILD_PREFIX%/include -DARROW_R_WITH_ARROW -DARROW_R_WITH_PARQUET -DARROW_R_WITH_DATASET -DARROW_R_WITH_JSON -DARROW_R_WITH_S3 -fvisibility-inlines-hidden -std=c++14 -fmessage-length=0 -march=k8 -mtune=haswell -ftree-vectorize -fstack-protector-strong -O2 -ffunction-sections -pipe -D_CRT_SECURE_NO_WARNINGS -D_MT -D_DLL -nostdlib -Xclang --dependent-lib=msvcrt -fuse-ld=lld -fno-aligned-allocation -c altrep.cpp -o altrep.o 
In file included from altrep.cpp:18:
././arrow_types.h:20:10: fatal error: 'cpp11/R.hpp' file not found
#include <cpp11/R.hpp>
         ^~~~~~~~~~~~~
1 error generated.
make: *** [altrep.o] Error 1
D:/bld/r-arrow_1636551521857/_h_env/lib/R/etc/x64/Makeconf:229: recipe for target 'altrep.o' failed
make: *** Waiting for unfinished jobs....
ERROR: compilation failed for package 'arrow'
* removing 'D:/bld/r-arrow_1636551521857/_h_env/Lib/R/library/arrow'

(%BUILD_PREFIX%) %SRC_DIR%>IF 1 NEQ 0 exit 1 
Traceback (most recent call last):
  File "C:\Miniconda\Scripts\conda-mambabuild-script.py", line 9, in <module>
    sys.exit(main())
  File "C:\Miniconda\lib\site-packages\boa\cli\mambabuild.py", line 215, in main
    call_conda_build(action, config)
  File "C:\Miniconda\lib\site-packages\boa\cli\mambabuild.py", line 187, in call_conda_build
    result = api.build(
  File "C:\Miniconda\lib\site-packages\conda_build\api.py", line 186, in build
    return build_tree(
  File "C:\Miniconda\lib\site-packages\conda_build\build.py", line 3083, in build_tree
    packages_from_this = build(metadata, stats,
  File "C:\Miniconda\lib\site-packages\conda_build\build.py", line 2174, in build
    return _func_defaulting_env_to_os_environ('call', *popenargs, **kwargs)
  File "C:\Miniconda\lib\site-packages\conda_build\utils.py", line 390, in _func_defaulting_env_to_os_environ
    raise subprocess.CalledProcessError(proc.returncode, _args)
subprocess.CalledProcessError: Command '['cmd.exe', '/d', '/c', 'conda_build.bat']' returned non-zero exit status 1.

The full log can be seen here: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=408497&view=logs&j=171a126d-c574-5c8c-1269-ff3b989e923d&t=1183ba29-a0b5-5324-8463-2a49ace9e213

Not sure how to fix it.

Maybe @xhochy could help?

@xhochy
Copy link
Member

xhochy commented Nov 12, 2021

@nealrichardson Do you have an idea what could be going wrong here?

Copy link
Contributor

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the issue is that we are still vendoring cpp11 but the configure.win that conda uses doesn't reflect that. Compare https://github.com/conda-forge/r-arrow-feedstock/blob/master/recipe/configure.win with https://github.com/apache/arrow/blob/master/dev/tasks/conda-recipes/r-arrow/configure.win. (The release process should really make sure that any changes accumulated in the apache/arrow version since the last release are pushed upstream.) I thought we had done a release since cpp11 was vendored so this change would already be there but apparently not?

@@ -76,16 +76,16 @@ extra:

# Package: arrow
# Title: R Integration to 'Apache' 'Arrow'
# Version: 0.12.1
# Version: 6.0.0.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is all in comments but it has drifted pretty far from the actual DESCRIPTION, not sure if that matters

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sure! It was just a quick edit to make the CI rebuild.

Sorry about that!

@gabrielmagno
Copy link
Contributor Author

gabrielmagno commented Nov 12, 2021

I think the issue is that we are still vendoring cpp11 but the configure.win that conda uses doesn't reflect that. Compare https://github.com/conda-forge/r-arrow-feedstock/blob/master/recipe/configure.win with https://github.com/apache/arrow/blob/master/dev/tasks/conda-recipes/r-arrow/configure.win. (The release process should really make sure that any changes accumulated in the apache/arrow version since the last release are pushed upstream.) I thought we had done a release since cpp11 was vendored so this change would already be there but apparently not?

@nealrichardson @xhochy Thanks! I've just copied the configure.win from upstream, and now the build passed.

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xhochy xhochy merged commit ec5b667 into conda-forge:master Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants