New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r-arrow v6.0.0 #43
r-arrow v6.0.0 #43
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2021.11.09.18.53.34
We'll probably have to wait for an additional hour until arrow-cpp 6.0 is available on the CDN. |
That's right, thanks for the comment. I was just ansious to test v6 and realized that it was not in conda-forge yet, and decided to do a PR. I just realized that there is a bot that automatically bumps the version or this repo. If you think it is better to let the bot do it, I can delete/close this PR. |
The Windows build failed. I will try to fix it, but not sure if I will be able to, since I'm not familiar with the Windows building pipeline. |
The error for the Windows build is this one:
The full log can be seen here: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=408497&view=logs&j=171a126d-c574-5c8c-1269-ff3b989e923d&t=1183ba29-a0b5-5324-8463-2a49ace9e213 Not sure how to fix it. Maybe @xhochy could help? |
@nealrichardson Do you have an idea what could be going wrong here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the issue is that we are still vendoring cpp11 but the configure.win
that conda uses doesn't reflect that. Compare https://github.com/conda-forge/r-arrow-feedstock/blob/master/recipe/configure.win with https://github.com/apache/arrow/blob/master/dev/tasks/conda-recipes/r-arrow/configure.win. (The release process should really make sure that any changes accumulated in the apache/arrow version since the last release are pushed upstream.) I thought we had done a release since cpp11 was vendored so this change would already be there but apparently not?
@@ -76,16 +76,16 @@ extra: | |||
|
|||
# Package: arrow | |||
# Title: R Integration to 'Apache' 'Arrow' | |||
# Version: 0.12.1 | |||
# Version: 6.0.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is all in comments but it has drifted pretty far from the actual DESCRIPTION, not sure if that matters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sure! It was just a quick edit to make the CI rebuild.
Sorry about that!
@nealrichardson @xhochy Thanks! I've just copied the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)