Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aarch64 builds #8

Merged
merged 3 commits into from
Sep 8, 2021
Merged

add aarch64 builds #8

merged 3 commits into from
Sep 8, 2021

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Aug 25, 2021

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@mr-c mr-c requested a review from croth1 as a code owner August 25, 2021 10:34
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@mr-c
Copy link
Contributor Author

mr-c commented Aug 25, 2021

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mr-c mr-c marked this pull request as draft August 25, 2021 10:47
@mr-c
Copy link
Contributor Author

mr-c commented Aug 29, 2021

@conda-forge-admin, please rerender

@mr-c mr-c changed the title add aarch64 and ppc64le builds add aarch64 builds Aug 29, 2021
@mr-c mr-c marked this pull request as ready for review August 29, 2021 09:37
@mr-c
Copy link
Contributor Author

mr-c commented Aug 29, 2021

@croth1 This is ready for review & merging ; thanks!

@mr-c
Copy link
Contributor Author

mr-c commented Sep 8, 2021

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2021

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

also use the correct SPDX license identifier
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • requirements: host: setuptools < 58 should not contain a space between relational operator and the version, i.e. setuptools <58
  • requirements: run: setuptools < 58 should not contain a space between relational operator and the version, i.e. setuptools <58

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • requirements: host: setuptools<58 must contain a space between the name and the pin, i.e. setuptools <58
  • requirements: run: setuptools<58 must contain a space between the name and the pin, i.e. setuptools <58

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mr-c
Copy link
Contributor Author

mr-c commented Sep 8, 2021

@croth1 Sorry to bother you again, can I get a review & merge?

@croth1 croth1 merged commit 9cd5bf6 into conda-forge:master Sep 8, 2021
@mr-c mr-c deleted the more_platforms branch September 8, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants