-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for testing rubin-env 8. #219
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also want to make sure we migrate cfitsio, log4cxx, and boost, and check compiler versions if we can upgrade.
- matplotlib-base !=3.6.0 | ||
- mkl # [linux64] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we fixing to mkl on linux? (May be fine, but not necessary I don't think).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have it in 7.0.1, so was just carrying it over. Remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was required because of the psfex problem. It should be optional and conda forge controllable I think
5886b58
to
2866aeb
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Compiler versions in conda-forge-pinning-feedstock are 12 (Linux) and 16 (OSX). FORTRAN is 12 on both. llvm_openmp goes to 16 (OSX only). Boost is still 1.78.0. cfitsio goes to 4.3.0. log4cxx is still 0.11.0; should we keep that or move up? |
I think we wanted to update log4cxx this time and I think we need to fix |
39254d0
to
6c809d1
Compare
If you check the migration PRs we should be able to do cfitsio and boost updates since I assume all the deps are migrated already. |
6c809d1
to
b65f334
Compare
8a404ff
to
ddadf35
Compare
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)