Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for testing rubin-env 8. #219

Merged
merged 5 commits into from
Dec 13, 2023
Merged

Conversation

ktlim
Copy link
Contributor

@ktlim ktlim commented Dec 12, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

recipe/meta.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also want to make sure we migrate cfitsio, log4cxx, and boost, and check compiler versions if we can upgrade.

- matplotlib-base !=3.6.0
- mkl # [linux64]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we fixing to mkl on linux? (May be fine, but not necessary I don't think).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have it in 7.0.1, so was just carrying it over. Remove it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was required because of the psfex problem. It should be optional and conda forge controllable I think

recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
@ktlim ktlim force-pushed the tickets/DM-42147-dev branch 2 times, most recently from 5886b58 to 2866aeb Compare December 13, 2023 01:05
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ktlim
Copy link
Contributor Author

ktlim commented Dec 13, 2023

Compiler versions in conda-forge-pinning-feedstock are 12 (Linux) and 16 (OSX). FORTRAN is 12 on both. llvm_openmp goes to 16 (OSX only). Boost is still 1.78.0. cfitsio goes to 4.3.0. log4cxx is still 0.11.0; should we keep that or move up?

@timj
Copy link
Contributor

timj commented Dec 13, 2023

I think we wanted to update log4cxx this time and I think we need to fix log at the same time because of an API change (lsst/log#67)

@erykoff
Copy link
Contributor

erykoff commented Dec 13, 2023

If you check the migration PRs we should be able to do cfitsio and boost updates since I assume all the deps are migrated already.

@ktlim ktlim merged commit 0e30c75 into conda-forge:dev Dec 13, 2023
6 checks passed
@ktlim ktlim deleted the tickets/DM-42147-dev branch December 13, 2023 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants