Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scip v900 #59

Merged
merged 8 commits into from
Feb 27, 2024
Merged

Scip v900 #59

merged 8 commits into from
Feb 27, 2024

Conversation

ju-manns
Copy link
Contributor

@ju-manns ju-manns commented Feb 6, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'papilo' output doesn't have any tests.
  • The boost-cpp output has been superseded by libboost-devel (as of 1.82), which now comes with a run-export (on libboost) as well. In case you only needed the boost headers, you should use libboost-headers.
  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@ju-manns ju-manns changed the title Scip v900 WIP: Scip v900 Feb 7, 2024
@ju-manns ju-manns marked this pull request as draft February 7, 2024 10:54
recipe/meta.yaml Outdated
folder: scipoptsuite
patches:
- 0002-Require-PCRE-on-WIN32.patch

build:
number: 7
number: 4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
number: 4
number: 0

We are starting back to zero with this version update (it should be checked at the PR, not commit level).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Thanks for reviewing!

@ju-manns ju-manns changed the title WIP: Scip v900 Scip v900 Feb 27, 2024
@ju-manns ju-manns marked this pull request as ready for review February 27, 2024 11:50
@ju-manns
Copy link
Contributor Author

@AntoinePrv we are ready to release :) can the branch be merged or do we need to update anything because some weeks have passed?

@AntoinePrv
Copy link
Contributor

@conda-forge-admin, please rerender

@AntoinePrv
Copy link
Contributor

@ju-manns, sorry, I thought you had write permission. Are you interested to join maintainers here?

@AntoinePrv AntoinePrv merged commit 2f0100d into conda-forge:main Feb 27, 2024
6 checks passed
@ju-manns
Copy link
Contributor Author

@ju-manns, sorry, I thought you had write permission. Are you interested to join maintainers here?

@AntoinePrv Yeah, that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants