Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SciPy v1.11.0 #235

Merged
merged 11 commits into from
Jun 26, 2023
Merged

SciPy v1.11.0 #235

merged 11 commits into from
Jun 26, 2023

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Jun 1, 2023

Let's try building 1.11.0!

Closes #241

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

Windows tests are irrelevant, that's just because the tests changed parametrization (& thus serialization). I'll let the CI run to completion then push a fix for that (also numpy upper bound).

@h-vetinari h-vetinari changed the title Scipy 1.11.0rc1 Scipy 1.11.0rc's Jun 18, 2023
@h-vetinari
Copy link
Member Author

So I don't know how this happened between rc1 & rc2, but we have two new crashes for PyPy + win

__________________ stats/tests/test_sensitivity_analysis.py ___________________
[gw1] win32 -- Python 3.9.16 %PREFIX%\python.exe
worker 'gw1' crashed while running 'stats/tests/test_sensitivity_analysis.py::TestSobolIndices::test_raises'
__________________________ stats/tests/test_stats.py __________________________
[gw0] win32 -- Python 3.9.16 %PREFIX%\python.exe
worker 'gw0' crashed while running 'stats/tests/test_stats.py::TestMode::test_negative_axes_gh_15375[axis0]'

In the same test suite run there was another test failing due to lack of memory:

E   numpy.core._exceptions._ArrayMemoryError: Unable to allocate 12.0 MiB for an array with shape (3, 1, 524288) and data type float64

so memory pressure might have something to do with it. I'll restart the builds once CI finishes to double-check.

That's unfortunate, but not enough to hold up the release IMO. CC @mattip

@mattip
Copy link
Contributor

mattip commented Jun 18, 2023

I tried running the pypy windows build on a VM with 10GB memory and it passed.

@h-vetinari
Copy link
Member Author

I tried running the pypy windows build on a VM with 10GB memory and it passed.

I guess we can just chalk that one up to memory pressure then and skip it here...

@h-vetinari h-vetinari changed the title Scipy 1.11.0rc's Scipy 1.11.0 Jun 25, 2023
@h-vetinari h-vetinari marked this pull request as ready for review June 25, 2023 20:45
@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Jun 25, 2023
@h-vetinari
Copy link
Member Author

Really no idea what change between rc2 & GA could cause PyPy to die on aarch/pcc...

@h-vetinari
Copy link
Member Author

Really no idea what change between rc2 & GA could cause PyPy to die on aarch/pcc...

And now the ppc one passed. Good enough for now, can still debug more later.

@h-vetinari h-vetinari changed the title Scipy 1.11.0 SciPy v1.11.0 Jun 26, 2023
@h-vetinari h-vetinari merged commit 85173fc into conda-forge:main Jun 26, 2023
23 of 25 checks passed
@h-vetinari h-vetinari deleted the rc branch June 26, 2023 07:08
@noamgat
Copy link

noamgat commented Jun 26, 2023

We are having a weird issue, when after updating to 1.11.0 in conda-forge, cvxpy fails to start:

Type "help", "copyright", "credits" or "license" for more information.                                                                                                                                                                             
>>> import scipy                                                                                                                                                                                                                                   
>>> scipy.__version__                                                                                                                                                                                                                              
'1.11.0'                                                                                                                                                                                                                                           
>>> import cvxpy                                                                                                                                                                                                                                   
Traceback (most recent call last):                                                                                                                                                                                                                 
  File "<stdin>", line 1, in <module>                                                                                                                                                                                                              
  File "/home/ubuntu/miniconda3/envs/algoenv/lib/python3.11/site-packages/cvxpy/__init__.py", line 18, in <module>                                                                                                                      
    import cvxpy.interface.scipy_wrapper                                                                                                                                                                                                           
  File "/home/ubuntu/miniconda3/envs/algoenv/lib/python3.11/site-packages/cvxpy/interface/scipy_wrapper.py", line 37, in <module>                                                                                                       
    method = getattr(spmatrix, method_name)                                                                                                                                                                                                        
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                                                                                        
AttributeError: type object 'spmatrix' has no attribute '__div__'. Did you mean: '__dir__'?```

@rgommers
Copy link
Contributor

@noamgat that seems like a SciPy bug, can you please open an issue at https://github.com/scipy/scipy/issues?

@h-vetinari
Copy link
Member Author

I started taking a look and my findings became long enough that I ended up filing an issue directly: scipy/scipy#18749

@h-vetinari
Copy link
Member Author

@noamgat, while we sort this out, the simplest (and essentially only) solution is to add a constraint scipy <1.11 to your environment.

PS. Thanks for the quick feedback!

@noamgat
Copy link

noamgat commented Jun 26, 2023

Thanks for opening the issue! I wasn't sure if it was related to the package or the feedstock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants