Add a 59.x LTS branch #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed because multiple projects need to pin to `setuptools < 60.0`, which was the release that enabled the vendored copy of `distutils` inside `setuptools`. That `distutils` copy contains backwards incompatible changes which NumPy and SciPy don't support; other projects like Pandas and Dask use that pin too because of the `LooseVersion` deprecation in 60.0 See conda-forge/conda-forge-repodata-patches-feedstock#204 for more details. [ci skip]
[ci skip]
rgommers
requested review from
isuruf,
jakirkham,
msarahan,
nicoddemus and
ocefpaf
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin rerender |
…nda-forge-pinning 2022.01.15.11.11.15
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
|
IDK why but azure missed the ci hook on the 59_x branch. I triggered it by hand for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed because multiple projects need to pin to
setuptools < 60.0, which was the release that enabled thevendored copy of
distutilsinsidesetuptools. Thatdistutilscopy contains backwards incompatible changes whichNumPy and SciPy don't support; other projects like Pandas and Dask use that pin too because of the
LooseVersiondeprecation in 60.0See conda-forge/conda-forge-repodata-patches-feedstock#204 for more details.
[ci skip]Also add myself as recipe maintainer.
Note: @beckermr suggested a procedure at conda-forge/conda-forge-repodata-patches-feedstock#204 (comment) that involves adding a branch to this repo (it should be named
59_xlike in this PR). I don't have permissions to push that branch, so it'd be great if a reviewer could do this.