Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert temporary fix for Issue 2911 #56

Closed
wants to merge 1 commit into from
Closed

Revert temporary fix for Issue 2911 #56

wants to merge 1 commit into from

Conversation

Sclare87
Copy link

@Sclare87 Sclare87 commented Jun 29, 2023

Issue is already resolved in shape project for 0.41.0. The temporary fix should not be necessary anymore.
I currently have problems with 0.41.0 version of conda packages because it uses old code.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The referenced fix was merged via shap/shap@a0b5ff8 This is a commit which has not been released yet and thus we shouldn't remove the pin.

What kind of issue are you seeing?

@Sclare87
Copy link
Author

Sclare87 commented Jun 29, 2023

Sorry okay maybe I was a little to fast with the Pull-Request.
Issue:

In my project i currently use the Version 0.41.0 from Conda-Forge together with Numpy 1.24.4.
Currently this is possible even with the Version restriction here in the meta.yaml.

So I get this Error:

shap_values = explainer.shap_values(data_df.to_numpy())
File "/------------------/lib/python3.10/site-packages/shap/explainers/_tree.py", line 384, in shap_values
X, y, X_missing, flat_output, tree_limit, check_additivity = self._validate_inputs(X, y,
File "/------------------/lib/python3.10/site-packages/shap/explainers/_tree.py", line 250, in _validate_inputs
X_missing = np.isnan(X, dtype=np.bool)\n File "/------------------/lib/python3.10/site-packages/numpy/init.py", line 305, in getattr
raise AttributeError(former_attrs[attr])
AttributeError: module 'numpy' has no attribute 'bool'.
np.bool was a deprecated alias for the builtin bool. To avoid this error in existing code, use bool by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use np.bool_ here.
The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at:
https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations"

I checked the code with shap code an found that with the Conda Package i dont get the 0.41.0 shap code instead i get an older version.

Its confusing.

Thanks for your help.

@Sclare87
Copy link
Author

Sclare87 commented Jun 29, 2023

Sorry the problem is i dont read the date of the commit and the releases.
Last release 2022 ... new changes 2023 ... so i must wait for 0.42 release. (or explicit use numpy < 1.24)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants