-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vsoch + add tests? #2
Conversation
@vsoch I had some of these tests in earlier iterations, but there were issues here and there. I am happy to add them again in this pr to assess how best to approach this. ## possible tests to run to ensure qc? # - pytest shpc/tests/test_settings.py # [not win] # ## ignore linux test because test returns verbose value # # - pytest shpc/tests/test_utils.py # [not linux64] # - pytest shpc/tests/test_container_config.py # [not win] # ## ignore othere tests because they trigger docker/singularity/podman
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2021.12.05.20.40.01
@ngam with respect to testing, my thinking for conda recipes is that the minimal test is just to do shpc --version (or version). Personally speaking I think shpc (at its repo) should be the main test runner - especially the tests here that require container technologies / lmod / modules that would need to be installed. We can't easily do that here. |
Yes, that was exactly my rationale, see initial pr and discussion (with myself) here: conda-forge/staged-recipes#17085 |
And especially that the build is pretty similar, etc. testing here wouldn't really be all that valuable. We usually like to do rigorous tests for more involved builds --- did you know we build singularity/ce itself here too? I am also adding apptainer soon to stay up to date with the drama 🤦 https://github.com/conda-forge/singularity-feedstock |
@vsoch, are you cool then with me merging this or would you like some more time to see if you'd like anything changed? Once merged, you will have the same access as me 😄 |
I think it looks great - merge away! |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
@vsoch (as per discussion in singularityhub/singularity-hpc#464) I had some of these tests in earlier iterations, but there were issues here and there. I am happy to add them again in this pr to assess how best to approach this.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)