Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding geemap package #11094

Merged
merged 3 commits into from
Mar 21, 2020
Merged

Adding geemap package #11094

merged 3 commits into from
Mar 21, 2020

Conversation

giswqs
Copy link
Member

@giswqs giswqs commented Mar 20, 2020 •
edited
Loading

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/geemap) and found it was in an excellent condition.

@giswqs
Copy link
Member Author

giswqs commented Mar 21, 2020

@conda-forge/help-python It is ready for review. Thanks.

npavlovikj
npavlovikj reviewed Mar 21, 2020
View reviewed changes
recipes/geemap/meta.yaml
sha256: 311b4c935575b41819c30d30ac01b7788e1f1d61e996734fb5f4a44945c6b32a

build:
number: 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the recipe can be noarch: python ?

npavlovikj
npavlovikj reviewed Mar 21, 2020
View reviewed changes
recipes/geemap/meta.yaml
script: "{{ PYTHON }} -m pip install . -vv"

requirements:
host:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually pip and python are enough for host dependencies.

npavlovikj
npavlovikj reviewed Mar 21, 2020
View reviewed changes
recipes/geemap/meta.yaml Outdated
home: "https://github.com/giswqs/geemap"
license: MIT
license_family: MIT
license_file:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add license file. If it is not part of the tarball, you can copy it from the repo.

@giswqs
Copy link
Member Author

giswqs commented Mar 21, 2020

@npavlovikj I have made changes as suggested. Thank you.

@giswqs giswqs requested a review from npavlovikj March 21, 2020 17:22
@npavlovikj npavlovikj merged commit efdf407 into conda-forge:master Mar 21, 2020
@npavlovikj
Copy link
Contributor

Thank you for contributing and the prompt fixes @giswqs !

@giswqs giswqs mentioned this pull request Apr 25, 2020
Closed
@giswqs giswqs mentioned this pull request Jun 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npavlovikj npavlovikj Awaiting requested review from npavlovikj

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@giswqs @conda-forge-linter @npavlovikj