Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add texlab 0.2.2 #12029

Merged
merged 17 commits into from
Jun 29, 2020
Merged

Add texlab 0.2.2 #12029

merged 17 commits into from
Jun 29, 2020

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Jun 28, 2020

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/texlab) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/texlab:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/texlab) and found it was in an excellent condition.

@bollwyvl bollwyvl closed this Jun 28, 2020
@bollwyvl bollwyvl reopened this Jun 28, 2020
@bollwyvl
Copy link
Contributor Author

@conda-forge/staged-recipes should I be concerned about the CircleCI failure?

is @conda-forge/help-rust a thing?

@bollwyvl
Copy link
Contributor Author

I had been working off a much-too-old master... have manually merged and force pushed

@bollwyvl bollwyvl closed this Jun 29, 2020
@bollwyvl bollwyvl reopened this Jun 29, 2020
@isuruf
Copy link
Member

isuruf commented Jun 29, 2020

See conda-forge/conda-forge.github.io#1052 about a license issue with Rust packages

@bollwyvl
Copy link
Contributor Author

license issue with Rust packages

Ooh, that sounds brutal! I'll read more in depth over there.

@bollwyvl
Copy link
Contributor Author

Using the techniques from conda-forge/conda-forge.github.io#1052 and pysyntect-feedstock, i've gotten it down to the following that will have to be tracked down by hand:

Licenses for the following dependencies are not being packaged:
* bytemuck (Zlib) -> https://github.com/Lokathor/bytemuck
* cesu8 (Apache-2.0 OR MIT) -> https://github.com/emk/cesu8-rs
* fuchsia-zircon-sys (BSD-3-Clause) -> https://fuchsia.googlesource.com/garnet/
* kernel32-sys (MIT) -> https://github.com/retep998/winapi-rs
* mac (Apache-2.0 OR MIT) -> https://github.com/reem/rust-mac.git
* siphasher (Apache-2.0 OR MIT) -> https://github.com/jedisct1/rust-siphash
* siphasher (Apache-2.0 OR MIT) -> https://github.com/jedisct1/rust-siphash
* strum (MIT) -> None
* strum_macros (MIT) -> None
* utf-8 (Apache-2.0 OR MIT) -> https://github.com/SimonSapin/rust-utf8
* void (MIT) -> https://github.com/reem/rust-void.git
* winapi-build (MIT) -> https://github.com/retep998/winapi-rs
* winapi-i686-pc-windows-gnu (Apache-2.0 OR MIT) -> https://github.com/retep998/winapi-rs
* winapi-x86_64-pc-windows-gnu (Apache-2.0 OR MIT) -> https://github.com/retep998/winapi-rs
* ws2_32-sys (MIT) -> https://github.com/retep998/winapi-rs

Still a fair amount, but less than 200 or whatever it started with...

@bollwyvl
Copy link
Contributor Author

Now running into this on windows:

python dep present in build but not host requirements

... since we use python to do the munging/checking, but don't want any build cruft.

i found this gitter from @isuruf... how'd you "properly" get around this issue?

For now I'm skipping the python-based stuff on windows, as all the win-64 stuff gets pulled in on linux, anyway.

@bollwyvl
Copy link
Contributor Author

Skipping the license check on windows seems to work fine:

(%PREFIX%) %SRC_DIR%>texlab --version 
texlab 2.2.0

(%PREFIX%) %SRC_DIR%>IF 0 NEQ 0 exit /B 1 

(%PREFIX%) %SRC_DIR%>exit /B 0 

(%PREFIX%) %SRC_DIR%>IF 0 NEQ 0 exit 1 

Resource usage statistics from testing texlab:
   Process count: 1
   CPU time: unavailable
   Memory: 1.5M
   Disk usage: 535B
   Time elapsed: 0:00:02.0

TEST END: C:\Miniconda\conda-bld\win-64\texlab-2.2.0-he32d670_0.tar.bz2

@bollwyvl
Copy link
Contributor Author

huzzah, back to green with all the licenses.

@conda-forge/staged-recipes have ticked all the boxes i can now...

@scopatz
Copy link
Member

scopatz commented Jun 29, 2020

Wow! You are a beast @bollwyvl!

@scopatz scopatz merged commit 063561a into conda-forge:master Jun 29, 2020
@isuruf
Copy link
Member

isuruf commented Jun 29, 2020

How is checking in unix enough? If there are windows only dependencies, the licenses will be missed.

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Jun 29, 2020 via email

@isuruf
Copy link
Member

isuruf commented Jun 29, 2020

You can fix that by adding compiler('c') to build.

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Jun 29, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants