-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add texlab 0.2.2 #12029
Add texlab 0.2.2 #12029
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/texlab:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/staged-recipes should I be concerned about the CircleCI failure? is @conda-forge/help-rust a thing? |
I had been working off a much-too-old |
See conda-forge/conda-forge.github.io#1052 about a license issue with Rust packages |
Ooh, that sounds brutal! I'll read more in depth over there. |
Using the techniques from conda-forge/conda-forge.github.io#1052 and pysyntect-feedstock, i've gotten it down to the following that will have to be tracked down by hand:
Still a fair amount, but less than 200 or whatever it started with... |
Now running into this on windows:
... since we use python to do the munging/checking, but don't want any build cruft. i found this gitter from @isuruf... how'd you "properly" get around this issue? For now I'm skipping the python-based stuff on windows, as all the win-64 stuff gets pulled in on linux, anyway. |
Skipping the license check on windows seems to work fine:
|
huzzah, back to green with all the licenses. @conda-forge/staged-recipes have ticked all the boxes i can now... |
Wow! You are a beast @bollwyvl! |
How is checking in unix enough? If there are windows only dependencies, the licenses will be missed. |
It pulls a number of win-rs packages (see licenses) that I assume are
windows only.... We could take the ten minute hit to build/install the
license tester, dump out the json and compare to other architectures. All
the checks are just commented out, and do work, but raise that python build
dep issue.
|
You can fix that by adding |
Awesome! Good to know. Will investigate restoring the checks on feedstock.
…On Mon, Jun 29, 2020, 17:48 Isuru Fernando ***@***.***> wrote:
You can fix that by adding compiler('c') to build.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12029 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALCRFCKW5DQDCLQX4D7RDRZED4TANCNFSM4OKT7DKA>
.
|
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details)