add xvega #12522

madhur-tandon · 2020-08-31T19:29:43Z

Checklist

Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
License file is packaged (see here for an example)
Source is from official source
Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
If static libraries are linked in, the license of the static library is packaged.
Build number is 0
A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

conda-forge-linter · 2020-08-31T19:29:56Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/xvega) and found some lint.

Here's what I've got...

For recipes/xvega:

There are too few lines. There should be one empty line at the end of the file.

For recipes/xvega:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

conda-forge-linter · 2020-08-31T19:32:41Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/xvega) and found it was in an excellent condition.

recipes/xvega/meta.yaml

recipes/xvega/build.sh

recipes/xvega/meta.yaml

SylvainCorlay · 2020-09-01T10:27:57Z

Thanks for the thorough review @scopatz.

I was a bit verbose/explicit with dependencies. I base them on what is imported by modules within the package. `dgl` could be added as a dependency if it's added to conda-forge. See dmlc/dgl#1855 and #12522 Even though this is a pure Python package, I run a few of the fastest tests that exercise different files, because this package has some heavy dependencies (pytorch, pytorch_geometric, etc) and I want that warm fuzzy feeling :) I get the tarball from github instead of PyPI, because the PyPI tarball does not (yet) contain the license file or the tests. Currently, the github tarball is not that much larger than from PyPI.

madhur-tandon added 2 commits September 1, 2020 00:47

add recipe for xvega

3119893

add home in the about section

442e3a7

fix linting issues

76d3fde

add xproperty as dependency

8928b6b

madhur-tandon changed the title ~~add recipe for xvega~~ add xvega Aug 31, 2020

fix dependencies

f48c005