Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add minigun #12540

Closed
wants to merge 3 commits into from
Closed

[WIP] add minigun #12540

wants to merge 3 commits into from

Conversation

hadim
Copy link
Member

@hadim hadim commented Sep 2, 2020

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/minigun) and found it was in an excellent condition.

@@ -0,0 +1,46 @@
{% set name = "minigun" %}
{% set version = "0.0.1.dev0" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a fully released version to build from?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we should wait to have a git tag before merging this. See dglai/minigun#14

recipes/minigun/meta.yaml Outdated Show resolved Hide resolved
@hadim
Copy link
Member Author

hadim commented Sep 2, 2020

@scopatz thanks for the review but this is WIP (sorry I should have mentioned it). Will ping again when I am done here.

@hadim hadim changed the title add minigun [WIP] add minigun Sep 2, 2020
@hadim
Copy link
Member Author

hadim commented Sep 2, 2020

Not sure this lib really make sense since it is only used in dgl and is headers only. Closing here.

@hadim hadim closed this Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants