-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new recipe for ConnectionPool #12676
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/connectionpool:
|
|
||
about: | ||
home: https://github.com/{{ author }}/{{ name }} | ||
# Remember to specify the license variants for BSD, Apache, GPL, and LGPL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove comments
script: $PYTHON -m pip install --no-deps --ignore-installed . | ||
|
||
requirements: | ||
build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be host
|
||
requirements: | ||
build: | ||
- python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you probably need pip here
|
||
about: | ||
home: https://github.com/jmeppley/{{ name }} | ||
summary: {{ summary }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably don't need two about sections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up just giving you what I think is a complete sample of what the recipe should look like. Also greetings from a fellow Haverford grad!
Also since the original package of the same name is up on pypi.io (https://pypi.org/project/connection-pool/) and you have a fork, I think we might want to be careful with the naming of the package so that there isn't confusion, unless the original project you forked from is known to no longer be developed and this is the official new branch of development. |
Thanks for the feedback, @synapticarbors and @scopatz. I just noticed that I changed the package name slightly from the original pip. I meant to use the same name. I'm not sure of the etiquette of taking on this project. I don't think it needs to be forked, but It seems like the original developer might have abandoned it, although it's only been a couple years. I've reached out to them and can wait a bit to see if I get a response. Do either of you have any suggestions on how to proceed? Either way, I should probably close this and re-open with either the pip name or a sufficiently different name. |
Checklist
The original developer hasn't responded to past pull requests, so I forked the project. This is a small little thing, but I think it could be useful to keep available as a separate project rather than just folding the code into where I'm going to use it.
(N/A)
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details)Attn: @conda-forge/help-python