Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added recipe for traceback2 #1308

Merged
merged 5 commits into from
Aug 25, 2016
Merged

Added recipe for traceback2 #1308

merged 5 commits into from
Aug 25, 2016

Conversation

pmlandwehr
Copy link
Contributor

No description provided.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/traceback2) and found it was in an excellent condition.

@pmlandwehr
Copy link
Contributor Author

linecache2 feedstock didn't render for py34 and osx for some reason. Re-running CI now; should fix the build.

@pmlandwehr
Copy link
Contributor Author

linecache2 is now present. Closing and reopening.

@pmlandwehr pmlandwehr closed this Aug 19, 2016
@pmlandwehr pmlandwehr reopened this Aug 19, 2016
@pmlandwehr
Copy link
Contributor Author

Travis CI seems stuck. Closing and reopening.

@pmlandwehr pmlandwehr closed this Aug 20, 2016
@pmlandwehr pmlandwehr reopened this Aug 20, 2016
jakirkham
jakirkham reviewed Aug 22, 2016
View reviewed changes
recipes/traceback2/meta.yaml

extra:
recipe-maintainers:
- pmlandwehr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anguslees, would you be willing to help maintain traceback2?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please feel free to add @anguslees here, @pmlandwehr, as he proposed such a recipe he was willing to maintain in PR ( #537 ). If I'm wrong about this assumption, please let us know, @anguslees, and we can take you off after.

@jakirkham
Copy link
Member

Toggling to restart build as Travis CI timed out.

@jakirkham jakirkham closed this Aug 22, 2016
@jakirkham jakirkham reopened this Aug 22, 2016
jakirkham
jakirkham reviewed Aug 22, 2016
View reviewed changes
recipes/traceback2/meta.yaml

about:
home: https://github.com/testing-cabal/traceback2
license: PSF 2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an issue upstream about including a license file in their sdists. Also please xref it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done - see issue 9

@pmlandwehr pmlandwehr mentioned this pull request Aug 23, 2016
Open
@jakirkham
Copy link
Member

Thanks @pmlandwehr. One more thing then am happy to merge.

@pmlandwehr
Copy link
Contributor Author

(ping @jakirkham for merge)

@jakirkham jakirkham merged commit 89683d6 into conda-forge:master Aug 25, 2016
@jakirkham
Copy link
Member

Thanks @pmlandwehr.

BTW we have been having some issues with Travis CI of late. So if it takes awhile to convert, that might be why.

@pmlandwehr pmlandwehr deleted the traceback2 branch September 6, 2016 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pmlandwehr @conda-forge-linter @jakirkham