Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding python-benedict, mailchecker #13326

Merged
merged 6 commits into from Nov 30, 2020
Merged

Conversation

pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Nov 25, 2020

Adds recipes for python-benedict and mailchecker (mailchecker is a benedict dependency).

Will resolve the benedict dependency for https://github.com/conda-forge/dvc-feedstock (related: iterative/dvc#4780).

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mailchecker, recipes/python-benedict) and found it was in an excellent condition.

@pmrowla
Copy link
Contributor Author

pmrowla commented Nov 25, 2020

Pinging @efiop and @shcheklein for confirmation on maintainers lists for these recipes

@fabiocaccamo
Copy link
Member

@pmrowla thank you for having added me as maintainer.

@shcheklein
Copy link
Member

Thanks, Peter! I confirm.

@efiop
Copy link
Member

efiop commented Nov 25, 2020

I confirm 🙂

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mailchecker, recipes/python-benedict) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/mailchecker:

  • noarch: python recipes are recommended to have a lower bound on the python version. This recommendation will become a requirement in the future.

For recipes/python-benedict:

  • noarch: python recipes are recommended to have a lower bound on the python version. This recommendation will become a requirement in the future.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mailchecker, recipes/python-benedict) and found it was in an excellent condition.

@dopplershift dopplershift merged commit 41388b1 into conda-forge:master Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants