Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doublemetaphone recipe #1365

Merged
merged 1 commit into from
Sep 3, 2016
Merged

Add doublemetaphone recipe #1365

merged 1 commit into from
Sep 3, 2016

Conversation

proinsias
Copy link
Contributor

@proinsias proinsias commented Aug 25, 2016 •
edited
Loading

  • Include license file from DoubleMetaphone once it has been provided – see my issue.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/doublemetaphone) and found it was in an excellent condition.

jakirkham
jakirkham reviewed Aug 25, 2016
View reviewed changes
recipes/doublemetaphone/build.sh
@@ -0,0 +1,9 @@
#!/bin/bash

$PYTHON setup.py install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop this file. No need as script does this for us.

@jakirkham
Copy link
Member

Thanks @proinsias. A couple of things to fix up. None of them should be too bad. Some of them should help with the CI failures.

Also please merge with master here and delete any recipes that you are not adding in this PR (except the example).

@proinsias
Copy link
Contributor Author

proinsias commented Aug 25, 2016 •
edited
Loading

I've pushed an update with most of the changes from @jakirkham – thanks for the help!

@proinsias proinsias mentioned this pull request Aug 25, 2016
Closed
Add doublemetaphone recipe
d6c8727 
Due to a Python 3
[issue](aerkalov/ebooklib#104) with the
ebooklib dependency, skip the Python 3 builds for now.
jakirkham
jakirkham reviewed Sep 3, 2016
View reviewed changes
recipes/doublemetaphone/meta.yaml

about:
license: MIT
# license_file: LICENSE # When added to MANIFEST.in – https://github.com/datamade/doublemetaphone/issues/1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xref: dedupeio/doublemetaphone#1
xref: dedupeio/doublemetaphone#2

@jakirkham jakirkham merged commit a5f7b4c into conda-forge:master Sep 3, 2016
@jakirkham
Copy link
Member

Thanks @proinsias.

@proinsias proinsias deleted the doublemetaphone branch September 6, 2016 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@proinsias @conda-forge-linter @jakirkham