Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding zoxide #13682

Merged
merged 3 commits into from
Jan 25, 2021
Merged

Adding zoxide #13682

merged 3 commits into from
Jan 25, 2021

Conversation

daizeng1984
Copy link
Member

@daizeng1984 daizeng1984 commented Jan 14, 2021

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/zoxide) and found some lint.

Here's what I've got...

For recipes/zoxide:

  • There are 1 too many lines. There should be one empty line at the end of the file.
  • Please do not delete the example recipe found in recipes/example/meta.yaml.

@daizeng1984
Copy link
Member Author

I'm willing to maintain

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/zoxide) and found it was in an excellent condition.

@daizeng1984
Copy link
Member Author

@conda-forge/staged-recipes please review

home: https://github.com/ajeetdsouza/zoxide
license: MIT
license_family: MIT
license_file: LICENSE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The licenses of the dependencies need to be included for rust packages. See conda-forge/conda-forge.github.io#1052 for a starting point

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trying to follow this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisburr done with the license files. Please take a look, thanks!

@daizeng1984
Copy link
Member Author

missing libray licenses:                                                                            
('clap', '3.0.0-beta.2', 'Apache-2.0 OR MIT', 'https://github.com/clap-rs/clap')                    
('clap_derive', '3.0.0-beta.2', 'Apache-2.0 OR MIT', 'https://github.com/clap-rs/clap/tree/master/clap_derive')
('remove_dir_all', '0.5.3', 'Apache-2.0 OR MIT', 'https://github.com/XAMPPRocky/remove_dir_all.git') 
('winapi-i686-pc-windows-gnu', '0.4.0', 'Apache-2.0 OR MIT', 'https://github.com/retep998/winapi-rs')
('winapi-x86_64-pc-windows-gnu', '0.4.0', 'Apache-2.0 OR MIT', 'https://github.com/retep998/winapi-rs')
52 having 'LICENSE-MIT', 11 having 'LICENSE*' or custom filename, 5 licenses are missing!!!; in total 68

@daizeng1984
Copy link
Member Author

Manually downloads:

Only in library_licenses/: clap-3.0.0-beta.2-license
Only in library_licenses/: clap_derive-3.0.0-beta.2-license
Only in library_licenses/: remove_dir_all-0.5.3-license
Only in library_licenses/: winapi-i686-pc-windows-gnu-0.4.0-license
Only in library_licenses/: winapi-x86_64-pc-windows-gnu-0.4.0-license

@chrisburr chrisburr merged commit 74a77ba into conda-forge:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants