Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fleur #14726

Merged
merged 20 commits into from
Mar 8, 2022
Merged

add fleur #14726

merged 20 commits into from
Mar 8, 2022

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Apr 25, 2021

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/fleur) and found some lint.

Here's what I've got...

For recipes/fleur:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/fleur) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/fleur) and found some lint.

Here's what I've got...

For recipes/fleur:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/fleur) and found it was in an excellent condition.

@janssenhenning
Copy link
Contributor

I'm willing to be listed as a maintainer here

@ltalirz
Copy link
Member Author

ltalirz commented Feb 11, 2022

@conda-forge/help-c-cpp PR is ready for review

- scalapack
- libxml2
- fftw
- spfft
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does your package need spfft at runtime? The build logs say that this library was not found during the build process.

Then we get overdependency warnings from conda-build.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spfft is an optional dependency that is probably not configured correctly in the recipe.
@ltalirz I think we can remove it for now since fftw is already included correctly

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the feedback guys; spfft removed

@carterbox
Copy link
Member

I tried restarting that linux build for you, but it didn't work. Mamba still wants to use openmpi-mpifort=4.0.2 instead of a newer build/version such as openmpi-mpifort=4.1. I'm not sure why it is choosing the older version of openmpi. The pinning is only to the major version.

@carterbox
Copy link
Member

The uninstallable openmpi-mpifort variant has been tagged for removal, but it may take 24 hours for the CDN to update. I'll check back within a few days.

recipes/fleur/meta.yaml Outdated Show resolved Hide resolved
@ltalirz
Copy link
Member Author

ltalirz commented Mar 8, 2022

Thanks a lot @carterbox and sorry for the slow response on my side.
Let's see whether this fixes it

recipes/fleur/meta.yaml Outdated Show resolved Hide resolved
Co-authored-by: Daniel Ching <carterbox@users.noreply.github.com>
@carterbox carterbox merged commit f83b0cd into conda-forge:main Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants