Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for rust-script #15297

Merged
merged 8 commits into from Jun 17, 2021
Merged

Add recipe for rust-script #15297

merged 8 commits into from Jun 17, 2021

Conversation

tedil
Copy link
Contributor

@tedil tedil commented Jun 15, 2021

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Note: This package has a dual license I'm not sure how to encode that in the meta.yaml. As recommended by @mbargull I now specify it according to SPDX as MIT AND Apache-2.0 (though it might be MIT OR Apache-2.0?); since rust-script copied their licensing from cargo, I guess it's the same issue.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/rust-script) and found some lint.

Here's what I've got...

For recipes/rust-script:

  • The recipe could do with some maintainers listed in the extra/recipe-maintainers section.
  • The recipe must have some tests.
  • The test section contained an unexpected subsection name. command is not a valid subsection name.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/rust-script) and found some lint.

Here's what I've got...

For recipes/rust-script:

  • The recipe could do with some maintainers listed in the extra/recipe-maintainers section.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/rust-script) and found some lint.

Here's what I've got...

For recipes/rust-script:

  • There are too few lines. There should be one empty line at the end of the file.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/rust-script) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/rust-script) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/rust-script:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/rust-script) and found it was in an excellent condition.

@xhochy
Copy link
Member

xhochy commented Jun 17, 2021

You will also need to add the thirdparty licenses that are installed alongside the main package, see #14985 for an example.

@tedil
Copy link
Contributor Author

tedil commented Jun 17, 2021

You will also need to add the thirdparty licenses that are installed alongside the main package, see #14985 for an example.

Thanks for the pointer, done ;)

@xhochy xhochy merged commit 880c950 into conda-forge:master Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants