Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added recipe for pysurvival #15709

Merged
merged 16 commits into from
Feb 14, 2022
Merged

Added recipe for pysurvival #15709

merged 16 commits into from
Feb 14, 2022

Conversation

sarthakpati
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pysurvival) and found it was in an excellent condition.

@stale
Copy link

stale bot commented Feb 12, 2022

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added the stale will be closed in 30 days label Feb 12, 2022
@stale stale bot removed the stale will be closed in 30 days label Feb 12, 2022
@sarthakpati
Copy link
Contributor Author

Hi @conda-forge/python, @conda-forge/staged-recipes, this is ready for review!

@xhochy
Copy link
Member

xhochy commented Feb 13, 2022

As this is a non-noarch package, you need to explicitly skip windows.

sarthakpati and others added 4 commits February 14, 2022 08:44
Co-authored-by: Mark Harfouche <mark.harfouche@gmail.com>
Co-authored-by: Mark Harfouche <mark.harfouche@gmail.com>
@sarthakpati
Copy link
Contributor Author

@hmaarrfk this looks good, now! Thanks a ton for your feedback. 😄 🚀

@hmaarrfk hmaarrfk merged commit 6326ed1 into conda-forge:main Feb 14, 2022
@sarthakpati sarthakpati deleted the pysurvival branch February 14, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants