-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipes for Chemfiles #1571
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/chemfiles:
For recipes/chemfiles-lib:
For recipes/chemfiles-python:
|
sha256: {{ sha256 }} | ||
|
||
requirements: | ||
build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add toolchain
. This configures the compiler to use and how to use it.
Thanks for proposing these, @Luthaf. Glad to see you over here. 😄 Tried to add some addition comments in addition to what the linter included. Once we get these cleaned up a bit more, we can take a closer look. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/chemfiles:
For recipes/chemfiles-lib:
For recipes/chemfiles-python:
|
I addressed most of the comments; still have to enable tests for chemfiles-lib and check for what is going on with |
I know the linter is mentioning tests. There are a couple types of tests we like to see. Running the test suite (mainly for compiled code) so For Python libraries import tests in the Some checks to make sure files (libraries, headers, configuration files, etc.) were installed where they should be. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I actually need to |
The Circle-CI failure is strange: I got an error about |
This is fixed by updating Boost, and I release the 0.6.2 version with this fix on Chemfiles. @jakirkham, I do not get the origin of the failure on travis/circle-ci, any idea? The Appveyor issue looks strange and related to installing libnetcdf with MSVC. |
Appveyor failure seems legitimate, the build log is
I do not know what I can do here. It may be related to #1678, but I need VS14 to build the code here. EDIT: maybe I can just disable the appveyor/windows version for now? |
Ping @jakirkham? I disabled the Windows version, it can be added later. |
So I'm in favor of merging. Though I'd like to save us some time restarting CIs. Could we please put the non-meta recipes (looks like the first 2 commits in a separate PR)? Once done please ping me and I will merge ASAP. Then we can cut this down the metapackage, which we can merge after the first two are built and deployed. Sound good? |
Sound good, I've separated the non-meta recipes in #1764 |
Thanks. Have gone ahead and merged that. It might be a little bit as conversion to feedstocks occurs on Travis CI ATM and they are a bit backed up as we speak. |
So we ran into some issues with |
Toggling for CI. |
Should I rebase and only include the meta recipe here? |
That sounds like a good idea. Sure let's do that. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
version: {{ version }} | ||
|
||
build: | ||
number: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add skip: true # [win]
. That should fix the CI failure. Also feel free to add [skip appveyor]
in your commit message to avoid having to run that CI as it is not used.
[skip appveyor]
Travis failure looks unrelated (502 gateway error from conda.anaconda.org), could you restart the build? |
Yep. Restarted. |
Thanks @Luthaf . |
A C++ library for reading/writing theoretical chemistry trajectories, with Python bindings. See http://chemfiles.github.io/ for more informations.
I added three recipes: C++ library, Python binding and meta-package. If you prefer having everything in one recipe, I can to it.