Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyPI package parquet-tools #15926

Merged
merged 6 commits into from
Aug 17, 2021

Conversation

jdblischak
Copy link
Member

@jdblischak jdblischak commented Aug 16, 2021

The license situation is a bit of a mess. I'd appreciate advice on how to to address these issues.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/parquet-tools) and found some lint.

Here's what I've got...

For recipes/parquet-tools:

  • license_file entry is missing, but is required.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/parquet-tools) and found it was in an excellent condition.

@jdblischak
Copy link
Member Author

I manually added a file with the MIT license. Should I also add a file with the Apache license?

@goanpeca
Copy link
Member

Hi @jdblischak thanks for submitting the recipe.

Could you open an issue https://github.com/ktrueda/parquet-tools and ask about the License status?

In the meantime maybe we should have it dual-licensed? Thoughts @conda-forge/staged-recipes ?

On another note, the CI is showing the following error:
RuntimeError: Could not download https://pypi.io/packages/source/p/parquet-tools/parquet-tools-0.2.6.tar.gz That URL indeed does not work

@isuruf
Copy link
Member

isuruf commented Aug 17, 2021

https://pypi.io/packages/source/p/parquet-tools/parquet-tools-0.2.6.tar.gz -> https://pypi.io/packages/source/p/parquet-tools/parquet_tools-0.2.6.tar.gz

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/parquet-tools) and found some lint.

Here's what I've got...

For recipes/parquet-tools:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/parquet-tools) and found it was in an excellent condition.

@ocefpaf ocefpaf merged commit e8f019d into conda-forge:master Aug 17, 2021
@jdblischak jdblischak deleted the pypi-parquet-tools branch August 17, 2021 18:10
@jdblischak
Copy link
Member Author

A quick update on how I handled the licensing situation. Fortunately the maintainer was receptive and helpful. I sent PR ktrueda/parquet-tools#16 to

  • add the file LICENSE.txt with the MIT license text (poetry automatically keeps this file during the build process, so no need for a MANIFEST.in)
  • exclude parquet.thrift from the built tarball. This Apache-licensed script is for code generation. It isn't needed for building or running the package code. So I removed it to avoid any issue with the Apache license

The maintainer published these changes on PyPI, and then I updated the feedstock in conda-forge/parquet-tools-feedstock#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants