Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dxtbx #16846

Merged
merged 26 commits into from Feb 10, 2022
Merged

Add dxtbx #16846

merged 26 commits into from Feb 10, 2022

Conversation

ndevenish
Copy link
Contributor

@ndevenish ndevenish commented Nov 8, 2021

Draft PR to test build since it doesn't seem to be working locally. An official (tagged) source will be used when ready to come out of draft.

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/dxtbx) and found some lint.

Here's what I've got...

For recipes/dxtbx:

  • requirements: host: cctbx-base>=2021.8 must contain a space between the name and the pin, i.e. cctbx-base >=2021.8
  • requirements: host: numpy<1.21 must contain a space between the name and the pin, i.e. numpy <1.21
  • requirements: run: python-dateutil>=2.7.0 must contain a space between the name and the pin, i.e. python-dateutil >=2.7.0
  • If python is a host requirement, it should be a run requirement.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/dxtbx) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/dxtbx) and found some lint.

Here's what I've got...

For recipes/dxtbx:

  • There are too few lines. There should be one empty line at the end of the file.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/dxtbx) and found it was in an excellent condition.

@Anthchirp
Copy link
Member

For the record: happy to be a maintainer

Copy link
Member

@Anthchirp Anthchirp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good judging from the recipe, haven't checked build output

recipes/dxtbx/meta.yaml Outdated Show resolved Hide resolved
recipes/dxtbx/meta.yaml Show resolved Hide resolved
@rjgildea
Copy link
Contributor

Happy to be listed as a maintainer 👍

@ndevenish ndevenish marked this pull request as ready for review February 10, 2022 19:22
@Anthchirp Anthchirp merged commit 17a33f0 into conda-forge:main Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants