Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trying singularityce again #17084

Merged
merged 7 commits into from
Dec 6, 2021
Merged

Conversation

ngam
Copy link
Contributor

@ngam ngam commented Nov 26, 2021

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/singularityce) and found it was in an excellent condition.

@ngam ngam changed the title WIP: trying singularityce again trying singularityce again Nov 26, 2021
@ngam
Copy link
Contributor Author

ngam commented Nov 26, 2021

@conda-forge/staged-recipes this is ready to go (only relevant build is on linux_64_centos7)

Please note and provide feedback:

  1. This is simply a copy with minor edits of the singularity-feedstock (https://github.com/conda-forge/singularity-feedstock). Sylabs (SingularityCE) forked HPCng's Singularity in May and now they're starting to diverge (confusingly). SingularityCE is backed by a commercial entity (while still open source) and thus their dev seems more focused and speedy. I thought we should add the CE fork feedstock to keep track of the changes and provide both the original and the fork. I am a maintainer on the singularity-feedstock, and I have added a conflict in the recipe here.
  2. I am not sure if we have preferences about using singularityce vs singularity-ce (they weirdly use them interchangeably, so I am not sure what you prefer/think is best)
  3. I disabled tests that require --privileged flag and will reenable those later when this becomes a feedstock
  4. I simply more or less copied from the singularity-feedstock --- is this okay? Do I need to rewrite stuff or like cite or something?

@ngam
Copy link
Contributor Author

ngam commented Dec 3, 2021

minor edits to bring macos up to speed; and now linux64 cos6 works fine.

@ngam ngam mentioned this pull request Dec 3, 2021
9 tasks
@ngam
Copy link
Contributor Author

ngam commented Dec 5, 2021

@conda-forge/staged-recipes gentle reminder to review this when you have a chance :)


# install
make install

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a make check we can run here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ocefpaf! I don't think so... or at least I haven't seen it.

For reference,

  1. this is our original singularity here at conda-forge: link
  2. and this is the dev install docs: link

Do you think we should be adding a make check here as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is available, yes. I'll leave that to you in the feedstock.

@ocefpaf ocefpaf merged commit cd8cc61 into conda-forge:main Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants