-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add charliecloud #17238
add charliecloud #17238
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
all good for now, next:
|
@conda-forge/staged-recipes this super neat and lightweight package is ready for your review. See my comment above about caveats re testing. Thanks! |
script: | ||
- ./configure --prefix=$PREFIX | ||
- make | ||
- make install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a make check we can run here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, but I will add it anyway. I will be doing more proper testing once this is a feedstock, but for that --privileged
flag will be needed.
ubuntu@primary:~/charliecloud-0.25$ make check
Making check in lib
make[1]: Entering directory '/home/ubuntu/charliecloud-0.25/lib'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/home/ubuntu/charliecloud-0.25/lib'
Making check in bin
make[1]: Entering directory '/home/ubuntu/charliecloud-0.25/bin'
make[1]: Leaving directory '/home/ubuntu/charliecloud-0.25/bin'
Making check in doc
make[1]: Entering directory '/home/ubuntu/charliecloud-0.25/doc'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/home/ubuntu/charliecloud-0.25/doc'
Making check in examples
make[1]: Entering directory '/home/ubuntu/charliecloud-0.25/examples'
ln -fTs dirCb copy/dirCa/symlink-to-dirCb
ln -fTs fileDa copy/dirD/symlink-to-fileDa
ln -fTs dirEb copy/dirEa/symlink-to-dirEb
ln -fTs filey copy/dirG/s_dir2
ln -fTs diry copy/dirG/s_dir3
ln -fTs filey copy/dirG/s_file2
ln -fTs diry copy/dirG/s_file3
ln -fTs fileA copy/symlink-to-fileA
ln -fTs fileB copy/symlink-to-fileB-A
ln -fTs fileB copy/symlink-to-fileB-B
make[1]: Leaving directory '/home/ubuntu/charliecloud-0.25/examples'
Making check in misc
make[1]: Entering directory '/home/ubuntu/charliecloud-0.25/misc'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/home/ubuntu/charliecloud-0.25/misc'
Making check in packaging
make[1]: Entering directory '/home/ubuntu/charliecloud-0.25/packaging'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/home/ubuntu/charliecloud-0.25/packaging'
Making check in test
make[1]: Entering directory '/home/ubuntu/charliecloud-0.25/test'
ln -fTs /tmp fixtures/symlink-to-tmp
make[1]: Leaving directory '/home/ubuntu/charliecloud-0.25/test'
make[1]: Entering directory '/home/ubuntu/charliecloud-0.25'
make[1]: Nothing to be done for 'check-am'.
make[1]: Leaving directory '/home/ubuntu/charliecloud-0.25'
@ocefpaf gentle nudge to merge this if you're satisfied with my edit above, thanks! Also tagging you in a related addition |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).