Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add charliecloud #17238

Merged
merged 52 commits into from
Dec 23, 2021
Merged

add charliecloud #17238

merged 52 commits into from
Dec 23, 2021

Conversation

ngam
Copy link
Contributor

@ngam ngam commented Dec 11, 2021

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/charliecloud) and found it was in an excellent condition.

@ngam
Copy link
Contributor Author

ngam commented Dec 11, 2021

TODO:
- [ ] skip ./configure
- [ ] add specs manually

@ngam
Copy link
Contributor Author

ngam commented Dec 11, 2021

all good for now, next:

  • sort out deps (host + run deps are mostly unneeded, wanna bundle?)
  • add proper testing (won't work with the missing namespaces?)
  • manipulate build further for enhancements?
  • add aarch+ppc [update: later]

  • ablation of deps... keeping some minimal deps (python, requests, squash, etc.) to ensure pkg works out-of-the-box...
  • Testing = difficult with issues related to user+mnt namespaces (see centos images & user+mnt namespaces docker-images#203)
  • build enhancements: nah, this is a "lazy" pkg where it assumes deps will exist later, and so the build is straightforward
  • aarch+ppc will be added once feedstock

@ngam
Copy link
Contributor Author

ngam commented Dec 11, 2021

@conda-forge/staged-recipes this super neat and lightweight package is ready for your review. See my comment above about caveats re testing. Thanks!

script:
- ./configure --prefix=$PREFIX
- make
- make install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a make check we can run here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, but I will add it anyway. I will be doing more proper testing once this is a feedstock, but for that --privileged flag will be needed.

ubuntu@primary:~/charliecloud-0.25$ make check
Making check in lib
make[1]: Entering directory '/home/ubuntu/charliecloud-0.25/lib'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/home/ubuntu/charliecloud-0.25/lib'
Making check in bin
make[1]: Entering directory '/home/ubuntu/charliecloud-0.25/bin'
make[1]: Leaving directory '/home/ubuntu/charliecloud-0.25/bin'
Making check in doc
make[1]: Entering directory '/home/ubuntu/charliecloud-0.25/doc'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/home/ubuntu/charliecloud-0.25/doc'
Making check in examples
make[1]: Entering directory '/home/ubuntu/charliecloud-0.25/examples'
ln -fTs dirCb copy/dirCa/symlink-to-dirCb
ln -fTs fileDa copy/dirD/symlink-to-fileDa
ln -fTs dirEb copy/dirEa/symlink-to-dirEb
ln -fTs filey copy/dirG/s_dir2
ln -fTs diry copy/dirG/s_dir3
ln -fTs filey copy/dirG/s_file2
ln -fTs diry copy/dirG/s_file3
ln -fTs fileA copy/symlink-to-fileA
ln -fTs fileB copy/symlink-to-fileB-A
ln -fTs fileB copy/symlink-to-fileB-B
make[1]: Leaving directory '/home/ubuntu/charliecloud-0.25/examples'
Making check in misc
make[1]: Entering directory '/home/ubuntu/charliecloud-0.25/misc'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/home/ubuntu/charliecloud-0.25/misc'
Making check in packaging
make[1]: Entering directory '/home/ubuntu/charliecloud-0.25/packaging'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/home/ubuntu/charliecloud-0.25/packaging'
Making check in test
make[1]: Entering directory '/home/ubuntu/charliecloud-0.25/test'
ln -fTs /tmp fixtures/symlink-to-tmp
make[1]: Leaving directory '/home/ubuntu/charliecloud-0.25/test'
make[1]: Entering directory '/home/ubuntu/charliecloud-0.25'
make[1]: Nothing to be done for 'check-am'.
make[1]: Leaving directory '/home/ubuntu/charliecloud-0.25'

@ngam
Copy link
Contributor Author

ngam commented Dec 22, 2021

@ocefpaf gentle nudge to merge this if you're satisfied with my edit above, thanks! Also tagging you in a related addition

@ocefpaf ocefpaf merged commit 3b70e29 into conda-forge:main Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants