-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding dimcli
from PyPI
#17275
Adding dimcli
from PyPI
#17275
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
- temporary hack: requirements.txt is missing in PyPI tar.gz - copy requires.txt and create requirements.txt
- for copying "requirements.txt" from "dimcli.egg-info/requires.txt" - copy only-if "requirements.txt" is not present already
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/dimcli:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
NoteThe PyPI package of Copying the
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/dimcli:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Request for review. cc: @conda-forge/help-python @dopplershift |
- to avoid error (win build)
{% set reqfile = "requirements.txt" %} | ||
{% set reqsource = "dimcli.egg-info/requires.txt" %} | ||
# IF {{ reqfile }} is NOT PRESENT, COPY {{ reqfile }} from {{ reqsource }} | ||
- if [ ! -f {{ reqfile }} ] && [ -f {{ reqsource }} ]; then cp {{ reqsource }} {{ reqfile }}; fi # [not win] | ||
- copy dimcli.egg-info\requires.txt {{ reqfile }} # [win] | ||
- {{ PYTHON }} -m pip install . -vv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kudos for this bit of magic!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hehe! Not quite!
If you see carefully, I was not able to apply the "IF" conditionals for windows. Any help/suggestion on what I should have done?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows has its own syntax that I usually find by looking through other recipes. IDK If you tried that. I don't see the problem with always copying requires though.
Thank you, for the lightning fast merge! ⚡ @beckermr |
Checklist
NA
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).