Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rabpro #18055

Merged
merged 5 commits into from
Feb 22, 2022
Merged

Add rabpro #18055

merged 5 commits into from
Feb 22, 2022

Conversation

jsta
Copy link
Member

@jsta jsta commented Feb 15, 2022

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/rabpro) and found some lint.

Here's what I've got...

For recipes/rabpro:

  • There are too few lines. There should be one empty line at the end of the file.
  • requirements: host: python>=3.7,<3.10 must contain a space between the name and the pin, i.e. python >=3.7,<3.10
  • requirements: run: geopandas>=0.7.0 must contain a space between the name and the pin, i.e. geopandas >=0.7.0
  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

For recipes/rabpro:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/rabpro) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/rabpro:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/rabpro) and found it was in an excellent condition.

@jsta
Copy link
Member Author

jsta commented Feb 15, 2022

I am willing to be listed as a maintainer.

1 similar comment
@jonschwenk
Copy link

I am willing to be listed as a maintainer.

@jsta
Copy link
Member Author

jsta commented Feb 17, 2022

@conda-forge-admin ping conda-forge/help-python please.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/help-python and so here I am doing that.

recipes/rabpro/meta.yaml Outdated Show resolved Hide resolved
recipes/rabpro/meta.yaml Outdated Show resolved Hide resolved
recipes/rabpro/meta.yaml Outdated Show resolved Hide resolved
Co-authored-by: Daniel Ching <carterbox@users.noreply.github.com>
@jsta
Copy link
Member Author

jsta commented Feb 22, 2022

@conda-forge-admin, please restart ci

Copy link
Member

@carterbox carterbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but waiting for Windows build check to finish.

@carterbox carterbox merged commit ab95dd7 into conda-forge:main Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants