Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add top2vec package #18064

Merged
merged 6 commits into from Feb 17, 2022
Merged

Add top2vec package #18064

merged 6 commits into from Feb 17, 2022

Conversation

llperez
Copy link
Contributor

@llperez llperez commented Feb 16, 2022

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/top2vec) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/top2vec) and found some lint.

Here's what I've got...

For recipes/top2vec:

  • requirements: build: python >= 3.6 should not contain a space between relational operator and the version, i.e. python >=3.6

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/top2vec) and found it was in an excellent condition.

@llperez
Copy link
Contributor Author

llperez commented Feb 17, 2022

@conda-forge-admin ping conda-forge/help-python please.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/help-python and so here I am doing that.

requirements:
build:
- python >=3.6
- cython
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure cython and a build section is required? Upstream looks like pure normal python.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BastianZim previous checks were failing as hdbscan depends on cython. Will try without the build section.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case please open an issue with hdbscan as that seems like an error with them: https://github.com/conda-forge/hdbscan-feedstock

If they don't reply soon we can keep it in here for now but then it would only be needed under run.

@llperez
Copy link
Contributor Author

llperez commented Feb 17, 2022

@BastianZim all good.

@BastianZim BastianZim merged commit 9d5db0d into conda-forge:main Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants