New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vegafusion-python-embed package #18081
Changes from 6 commits
07225e2
5067f40
255d7e1
bc5b6bd
e01f791
6cfde04
784e7ec
8469140
fb7f493
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,57 @@ | ||||||||||||
{% set name = "vegafusion-python-embed" %} | ||||||||||||
{% set name_under = "vegafusion_python_embed" %} | ||||||||||||
{% set version = "0.0.4_rc.1" %} | ||||||||||||
|
||||||||||||
package: | ||||||||||||
name: {{ name|lower }} | ||||||||||||
version: {{ version }} | ||||||||||||
|
||||||||||||
source: | ||||||||||||
url: https://pypi.io/packages/source/{{ name_under[0] }}/{{ name_under }}/{{ name_under }}-{{ version }}.tar.gz | ||||||||||||
sha256: d5582e82ec482e9327ab53ac6047826effa0e4ac6bc1d0e81b9fe5818f09d1da | ||||||||||||
|
||||||||||||
build: | ||||||||||||
number: 0 | ||||||||||||
script: | | ||||||||||||
export RUSTFLAGS="--cfg unsound_local_offset" # [not win] | ||||||||||||
set RUSTFLAGS=--cfg unsound_local_offset # [win] | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the "safe way" is to put a quotes around the entire env var plus value, like There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks! Giving that a try now |
||||||||||||
cargo-bundle-licenses --format yaml --output THIRDPARTY.yml | ||||||||||||
{{ PYTHON }} -m pip install . -vv | ||||||||||||
|
||||||||||||
requirements: | ||||||||||||
build: | ||||||||||||
- {{ compiler('c') }} # [not win] | ||||||||||||
- {{ compiler('m2w64_c') }} # [win] | ||||||||||||
- {{ compiler('rust') }} | ||||||||||||
- cargo-bundle-licenses | ||||||||||||
host: | ||||||||||||
- python | ||||||||||||
- pip | ||||||||||||
- maturin | ||||||||||||
run: | ||||||||||||
- python | ||||||||||||
|
||||||||||||
test: | ||||||||||||
requires: | ||||||||||||
- pip | ||||||||||||
commands: | ||||||||||||
- pip check | ||||||||||||
Comment on lines
+37
to
+38
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||
|
||||||||||||
about: | ||||||||||||
home: https://vegafusion.io | ||||||||||||
license: AGPL-3.0-or-later | ||||||||||||
license_family: GPL | ||||||||||||
license_file: | ||||||||||||
- LICENSE | ||||||||||||
- THIRDPARTY.yml | ||||||||||||
|
||||||||||||
summary: 'Server-side acceleration for the Vega visualization grammar' | ||||||||||||
description: | | ||||||||||||
VegaFusion provides serverside acceleration for the Vega visualization grammer. The vegafusion-python-embed | ||||||||||||
package is generally used as a dependency of higher-level, pure-Python, packages like vegafusion-jupyter. | ||||||||||||
doc_url: https://vegafusion.io | ||||||||||||
dev_url: https://github.com/vegafusion/vegafusion | ||||||||||||
|
||||||||||||
extra: | ||||||||||||
recipe-maintainers: | ||||||||||||
- jonmmease |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
import vegafusion_embed | ||
vegafusion_embed.PyTaskGraphRuntime(4) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this an RC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @wolfv! I agree this should build from an actual release if at all possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is an RC because the current stable version doesn't have sdist bundles published. If this approach looks good otherwise, I can publish a new version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if you're ready to release
0.0.4
proper then this recipe is in good shape to be merged.Ofc, it's always possible further 👀 will pick up some more issues but it's easier for others to review when it's ready to merge (otherwise it would need a further review when it was ready)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI running on version 0.0.4