Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding neuralforecast from PyPI #18423

Merged
merged 7 commits into from
Mar 23, 2022
Merged

Conversation

sugatoray
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/neuralforecast) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/neuralforecast:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/neuralforecast) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/neuralforecast) and found some lint.

Here's what I've got...

For recipes/neuralforecast:

  • requirements: run: pyDeprecate==0.3.1 must contain a space between the name and the pin, i.e. pyDeprecate ==0.3.1

@sugatoray
Copy link
Contributor Author

Pip Check failed: Reason

(error)

import: 'neuralforecast'
+ pip check
pytorch-lightning 1.5.10 has requirement pyDeprecate==0.3.1, but you have pydeprecate 0.3.2.
py7zr 0.18.1 has requirement pyppmd<0.18.0,>=0.17.0, but you have pyppmd 0.18.0.
py7zr 0.18.1 has requirement zipfile-deflate64>=0.2.0, but you have zipfile-deflate64 0.0.0.
Tests failed for neuralforecast-0.0.7-pyhd8ed1ab_0.tar.bz2 - moving package to /home/conda/staged-recipes/build_artifacts/broken
WARNING:conda_build.build:Tests failed for neuralforecast-0.0.7-pyhd8ed1ab_0.tar.bz2 - moving package to /home/conda/staged-recipes/build_artifacts/broken
TESTS FAILED: neuralforecast-0.0.7-pyhd8ed1ab_0.tar.bz2
##[error]Bash exited with code '1'.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/neuralforecast) and found it was in an excellent condition.

@sugatoray
Copy link
Contributor Author

Build Fails at pip-check

(error)

import: 'neuralforecast'
+ pip check
py7zr 0.18.1 has requirement zipfile-deflate64>=0.2.0, but you have zipfile-deflate64 0.0.0.
Tests failed for neuralforecast-0.0.7-pyhd8ed1ab_0.tar.bz2 - moving package to /home/conda/staged-recipes/build_artifacts/broken
WARNING:conda_build.build:Tests failed for neuralforecast-0.0.7-pyhd8ed1ab_0.tar.bz2 - moving package to /home/conda/staged-recipes/build_artifacts/broken
TESTS FAILED: neuralforecast-0.0.7-pyhd8ed1ab_0.tar.bz2
##[error]Bash exited with code '1'.

@sugatoray
Copy link
Contributor Author

Reason for Windows build failure

PyTorch is not avilable on conda-forge for windows platform.

@sugatoray
Copy link
Contributor Author

PR is ready. Request for review/merging.

cc: @conda-forge/help-python

Copy link
Member

@BastianZim BastianZim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of things then this is ready.

recipes/neuralforecast/meta.yaml Show resolved Hide resolved
recipes/neuralforecast/meta.yaml Show resolved Hide resolved
Comment on lines +43 to +45
# pyppmd and zipfile-deflate constraints are necessary for py7zr
- pyppmd >=0.17.0,<0.18.0
- zipfile-deflate64 >=0.2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add an issue in the py7zr feedstock to have this updated or make a PR there yourself?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Thank you. Will do.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BastianZim BastianZim merged commit 8fd53c2 into conda-forge:main Mar 23, 2022
@sugatoray
Copy link
Contributor Author

@BastianZim Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants