Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added recipe for semi-ate-spyder #18853

Merged
merged 31 commits into from
May 12, 2022
Merged

Conversation

nerohmot
Copy link
Contributor

@nerohmot nerohmot commented May 4, 2022

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/semi-ate-spyder) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/semi-ate-spyder) and found some lint.

Here's what I've got...

For recipes/semi-ate-spyder:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.
  • requirements: run: Jinja2<3.1,>=2.10 must contain a space between the name and the pin, i.e. Jinja2 <3.1,>=2.10

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/semi-ate-spyder) and found some lint.

Here's what I've got...

For recipes/semi-ate-spyder:

  • requirements: run: Jinja2<3.1 >=2.10 must contain a space between the name and the pin, i.e. Jinja2 <3.1>=2.10

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/semi-ate-spyder) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/semi-ate-spyder) and found some lint.

Here's what I've got...

For recipes/semi-ate-spyder:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/semi-ate-spyder) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/semi-ate-spyder) and found some lint.

Here's what I've got...

For recipes/semi-ate-spyder:

  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/semi-ate-spyder) and found some lint.

Here's what I've got...

For recipes/semi-ate-spyder:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/semi-ate-spyder) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/semi-ate-spyder) and found some lint.

Here's what I've got...

For recipes/semi-ate-spyder:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/semi-ate-spyder) and found some lint.

Here's what I've got...

For recipes/semi-ate-spyder:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@nerohmot
Copy link
Contributor Author

nerohmot commented May 6, 2022

@goanpeca
Hi Gonzalo,
if I add the pip check again then OSX starts failing
image
with as a trace :
image
applauncherservices is introduced by spyder, and as spyder is ofcourse a dependency of this spyder-plugin ...
image
as a compromise, is it acceptable that I do the same as the spyder recipe ie : pip check # [linux or win] ?
image

@nerohmot
Copy link
Contributor Author

nerohmot commented May 6, 2022

I also asked @ccordoba12 for a 'cleaner' solution from spyder side in spyder-ide/spyder#17835, but I would appreciate it if we can proceed as proposed, and not have to wait for the cleaner solution 😇

@BastianZim
Copy link
Member

Since it’s noarch it will only be built on Linux in the feedstock and we can ignore the OSX failure here.

recipes/semi-ate-spyder/meta.yaml Outdated Show resolved Hide resolved
nerohmot and others added 2 commits May 7, 2022 07:21
Co-authored-by: Daniel Ching <carterbox@users.noreply.github.com>
@nerohmot
Copy link
Contributor Author

nerohmot commented May 7, 2022

@carterbox, you would think so, however when applying your suggestion I get :
image
With as win_64 trace:
image
and as trace for linux_64 :
image
So before going down the jinja2 rabbit hole, I first tried to force numpydoc to the latest version (hence the =1.3.1) and luckily for me conda found a solution for that!!! 😅

@goanpeca
Copy link
Member

@nerohmot I meant you could remove those lines instead of leaving commented :)

Since it’s noarch it will only be built on Linux in the feedstock and we can ignore the OSX failure here.

Also agree with this.

Copy link
Member

@goanpeca goanpeca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the recipe @nerohmot

@nerohmot
Copy link
Contributor Author

@conda-forge/staged-recipes Can we merge now?

@carterbox
Copy link
Member

numpydoc 1.2.1 has requirement Jinja2<3.1,>=2.10, but you have jinja2 3.1.2.

This error does not say that your package requires numpydoc. It says that numpydoc was installed in the test environment and the numpydoc=1.2.1 package is broken.

@carterbox
Copy link
Member

Also, you don't need to take screenshots. If you want to quote relevant text, just copy the log text directly.

recipes/semi-ate-spyder/meta.yaml Outdated Show resolved Hide resolved
@carterbox
Copy link
Member

There's probably a similar issue with applaunchservices. That package incorrectly specified their dependencies / didn't do pip check in their feedstock, so the pip check error shows up here. Figure out which build of applaunchservices isn't broken and add that as a constraint to your test environment.

@ccordoba12
Copy link
Contributor

ccordoba12 commented May 12, 2022

@carterbox, applaunchservices is a Spyder dependency and at the moment we're figuring out how to solve the problem related to it in conda-forge. I think it has to do with some Pyobjc libraries missing, but I haven't had time to take a look at it in depth.

So we'd appreciate if this PR could be merged as it is because I think it's not for @nerohmot to sort that out.

@nerohmot nerohmot requested a review from carterbox May 12, 2022 16:09
@carterbox carterbox merged commit 5f45ee0 into conda-forge:main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

7 participants