Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding arrow-odbc #19001

Merged
merged 6 commits into from
Aug 25, 2022
Merged

adding arrow-odbc #19001

merged 6 commits into from
Aug 25, 2022

Conversation

timkpaine
Copy link
Member

@timkpaine timkpaine commented May 19, 2022

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/arrow-odbc) and found some lint.

Here's what I've got...

For recipes/arrow-odbc:

  • The requirements/ sections should be defined in the following order: build, host, run; instead saw: host, build, run.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/arrow-odbc) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/arrow-odbc) and found it was in an excellent condition.

@timkpaine
Copy link
Member Author

timkpaine commented Jul 6, 2022

@xhochy sorry to bother you, any thoughts on the failure?

   Compiling native v0.1.0 (/tmp/build-via-sdist-rs6i1kb2/arrow-odbc-0.1.21/rust)
    Finished release [optimized] target(s) in 2m 50s
Traceback (most recent call last):
  File "/home/conda/staged-recipes/build_artifacts/arrow-odbc_1656702594977/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.9/site-packages/pep517/in_process/_in_process.py", line 363, in <module>
    main()
  File "/home/conda/staged-recipes/build_artifacts/arrow-odbc_1656702594977/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.9/site-packages/pep517/in_process/_in_process.py", line 345, in main
    json_out['return_val'] = hook(**hook_input['kwargs'])
  File "/home/conda/staged-recipes/build_artifacts/arrow-odbc_1656702594977/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.9/site-packages/pep517/in_process/_in_process.py", line 261, in build_wheel
    return _build_backend().build_wheel(wheel_directory, config_settings,
  File "/home/conda/staged-recipes/build_artifacts/arrow-odbc_1656702594977/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.9/site-packages/setuptools/build_meta.py", line 244, in build_wheel
    return self._build_with_temp_dir(['bdist_wheel'], '.whl',
  File "/home/conda/staged-recipes/build_artifacts/arrow-odbc_1656702594977/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.9/site-packages/setuptools/build_meta.py", line 229, in _build_with_temp_dir
    self.run_setup()
  File "/home/conda/staged-recipes/build_artifacts/arrow-odbc_1656702594977/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.9/site-packages/setuptools/build_meta.py", line 174, in run_setup
    exec(compile(code, __file__, 'exec'), locals())
  File "setup.py", line 21, in <module>
    setup(
  File "/home/conda/staged-recipes/build_artifacts/arrow-odbc_1656702594977/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.9/site-packages/setuptools/__init__.py", line 87, in setup
    return distutils.core.setup(**attrs)
  File "/home/conda/staged-recipes/build_artifacts/arrow-odbc_1656702594977/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.9/site-packages/setuptools/_distutils/core.py", line 177, in setup
    return run_commands(dist)
  File "/home/conda/staged-recipes/build_artifacts/arrow-odbc_1656702594977/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.9/site-packages/setuptools/_distutils/core.py", line 193, in run_commands
    dist.run_commands()
  File "/home/conda/staged-recipes/build_artifacts/arrow-odbc_1656702594977/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.9/site-packages/setuptools/_distutils/dist.py", line 968, in run_commands
    self.run_command(cmd)
  File "/home/conda/staged-recipes/build_artifacts/arrow-odbc_1656702594977/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.9/site-packages/setuptools/dist.py", line 1229, in run_command
    super().run_command(command)
  File "/home/conda/staged-recipes/build_artifacts/arrow-odbc_1656702594977/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.9/site-packages/setuptools/_distutils/dist.py", line 987, in run_command
    cmd_obj.run()
  File "/home/conda/staged-recipes/build_artifacts/arrow-odbc_1656702594977/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.9/site-packages/wheel/bdist_wheel.py", line 299, in run
    self.run_command('build')
  File "/home/conda/staged-recipes/build_artifacts/arrow-odbc_1656702594977/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.9/site-packages/setuptools/_distutils/cmd.py", line 317, in run_command
    self.distribution.run_command(command)
  File "/home/conda/staged-recipes/build_artifacts/arrow-odbc_1656702594977/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.9/site-packages/setuptools/dist.py", line 1229, in run_command
    super().run_command(command)
  File "/home/conda/staged-recipes/build_artifacts/arrow-odbc_1656702594977/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.9/site-packages/setuptools/_distutils/dist.py", line 987, in run_command
    cmd_obj.run()
  File "/home/conda/staged-recipes/build_artifacts/arrow-odbc_1656702594977/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.9/site-packages/setuptools/command/build.py", line 24, in run
    super().run()
  File "/home/conda/staged-recipes/build_artifacts/arrow-odbc_1656702594977/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.9/site-packages/setuptools/_distutils/command/build.py", line 131, in run
    self.run_command(cmd_name)
  File "/home/conda/staged-recipes/build_artifacts/arrow-odbc_1656702594977/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.9/site-packages/setuptools/_distutils/cmd.py", line 317, in run_command
    self.distribution.run_command(command)
  File "/home/conda/staged-recipes/build_artifacts/arrow-odbc_1656702594977/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.9/site-packages/setuptools/dist.py", line 1229, in run_command
    super().run_command(command)
  File "/home/conda/staged-recipes/build_artifacts/arrow-odbc_1656702594977/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.9/site-packages/setuptools/_distutils/dist.py", line 987, in run_command
    cmd_obj.run()
  File "/home/conda/staged-recipes/build_artifacts/arrow-odbc_1656702594977/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.9/site-packages/milksnake/setuptools_ext.py", line 88, in run
    func(base_path=base_path, inplace=False)
  File "/home/conda/staged-recipes/build_artifacts/arrow-odbc_1656702594977/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.9/site-packages/milksnake/setuptools_ext.py", line 269, in build_cffi
    dylib = self.dylib()
  File "setup.py", line 10, in <lambda>
    dylib=lambda: build.find_dylib("native", in_path="/target/release"),
  File "/home/conda/staged-recipes/build_artifacts/arrow-odbc_1656702594977/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.9/site-packages/milksnake/setuptools_ext.py", line 160, in find_dylib
    raise LookupError('dylib %r not found' % name)

@timkpaine
Copy link
Member Author

@pacman82 any interest in being on this feedstock?

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/arrow-odbc) and found some lint.

Here's what I've got...

For recipes/arrow-odbc:

  • requirements: host: maturin>=0.13,<0.14 must contain a space between the name and the pin, i.e. maturin >=0.13,<0.14

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/arrow-odbc) and found it was in an excellent condition.

@pacman82
Copy link
Contributor

@timkpaine hey, thanks for adding this to conda! Sure, I am busy right now and my conda forge knowledge is somewhat limited, but I am happy to help out if I can.

@pacman82
Copy link
Contributor

You seem on the right track of fixing it though ...

It's important that it goes against the system preinstalled unixodbc, and unixodbc is not packaged together with arrow-odbc, for both technical and licensing issues.

@timkpaine timkpaine marked this pull request as ready for review August 23, 2022 21:03
@timkpaine timkpaine requested a review from xhochy August 23, 2022 21:03
@pacman82
Copy link
Contributor

🎉

@timkpaine
Copy link
Member Author

@conda-forge/help-python all set

@xhochy xhochy merged commit 99ca82b into conda-forge:main Aug 25, 2022
@timkpaine timkpaine mentioned this pull request Sep 9, 2023
10 tasks
@timkpaine timkpaine deleted the arrow-odbc branch September 9, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants