Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding chalk-diagrams from PyPI #19013

Merged
merged 4 commits into from
May 23, 2022
Merged

Conversation

sugatoray
Copy link
Contributor

@sugatoray sugatoray commented May 19, 2022

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/chalk-diagrams) and found some lint.

Here's what I've got...

For recipes/chalk-diagrams:

  • The license item is expected in the about section.
  • There are too few lines. There should be one empty line at the end of the file.

@sugatoray
Copy link
Contributor Author

sugatoray commented May 19, 2022

Linting Failure

The linting check fails as the LICENSE file included now is just a dummy file. Once the upstream repository includes a license file (currently absent), this will be fixed.

Opened an issue to add the license file to the upstream-repository and also to the PyPI source.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/chalk-diagrams) and found some lint.

Here's what I've got...

For recipes/chalk-diagrams:

  • There are too few lines. There should be one empty line at the end of the file.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/chalk-diagrams) and found it was in an excellent condition.

@sugatoray sugatoray marked this pull request as ready for review May 21, 2022 01:37
@sugatoray
Copy link
Contributor Author

PR is ready. Request for review/merging.

cc: @conda-forge/help-python

@BastianZim
Copy link
Member

If you have the time, it would be nice if you could patch the Windows error as well upstream. Or are you already doing that somewhere?

@BastianZim BastianZim merged commit a04420c into conda-forge:main May 23, 2022
@sugatoray
Copy link
Contributor Author

@BastianZim The upstream maintainers only tested this on Mac OS and Linux so far. So, am not aware of any fix being worked on.

If I were to use a patch, how would I?

@BastianZim
Copy link
Member

Ahh ok then it's not a problem.

UnicodeDecodeError: 'charmap' codec can't decode byte 0x8f in position 544: character maps to <undefined> this line generally occurs when there is a funny character in the readme or so but I haven't actually checked if that's the case – was just suspecting it.

Ref: https://stackoverflow.com/questions/9233027/unicodedecodeerror-charmap-codec-cant-decode-byte-x-in-position-y-character

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants