Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add pytorch dependencies #19103

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented May 29, 2022

Results:

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cpuinfo) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/cpuinfo) and found some lint.

Here's what I've got...

For recipes/cpuinfo:

  • The build section contained an unexpected subsection name. run_export is not a valid subsection name.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cpuinfo) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/clog, recipes/cpuinfo) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cpuinfo) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cpuinfo, recipes/psimd) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cpuinfo, recipes/fp16, recipes/psimd) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cpuinfo, recipes/fp16, recipes/fxdiv, recipes/psimd) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cpuinfo, recipes/fp16, recipes/fxdiv, recipes/psimd, recipes/pthreadpool) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/pthreadpool:

  • Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [22].

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cpuinfo, recipes/fp16, recipes/fxdiv, recipes/psimd, recipes/pthreadpool, recipes/qnnpack) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/clog, recipes/cpuinfo, recipes/fp16, recipes/fxdiv, recipes/psimd, recipes/pthreadpool, recipes/qnnpack) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/clog, recipes/cpuinfo, recipes/fp16, recipes/fxdiv, recipes/psimd, recipes/pthreadpool, recipes/qnnpack, recipes/xnnpack) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/clog, recipes/cpuinfo, recipes/fp16, recipes/fxdiv, recipes/opcodes, recipes/psimd, recipes/pthreadpool, recipes/qnnpack, recipes/xnnpack) and found some lint.

Here's what I've got...

For recipes/opcodes:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

For recipes/pthreadpool:

  • Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [22].

@ngam
Copy link
Contributor

ngam commented May 29, 2022

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/clog, recipes/cpuinfo, recipes/fp16, recipes/fxdiv, recipes/opcodes, recipes/peachpy, recipes/psimd, recipes/pthreadpool, recipes/qnnpack, recipes/xnnpack) and found some lint.

Here's what I've got...

For recipes/opcodes:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

For recipes/peachpy:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

For recipes/pthreadpool:

  • Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [22].

@hmaarrfk hmaarrfk force-pushed the pytorch_deps branch 2 times, most recently from 944b743 to 4404a6d Compare May 29, 2022 15:00
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/clog, recipes/cpuinfo, recipes/fp16, recipes/fxdiv, recipes/opcodes, recipes/peachpy, recipes/psimd, recipes/pthreadpool, recipes/qnnpack, recipes/xnnpack) and found some lint.

Here's what I've got...

For recipes/opcodes:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

For recipes/peachpy:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/clog, recipes/cpuinfo, recipes/fp16, recipes/fxdiv, recipes/opcodes, recipes/peachpy, recipes/psimd, recipes/pthreadpool, recipes/qnnpack, recipes/xnnpack) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/clog, recipes/cpuinfo, recipes/fp16, recipes/fxdiv, recipes/nnpack, recipes/opcodes, recipes/peachpy, recipes/psimd, recipes/pthreadpool, recipes/qnnpack, recipes/xnnpack) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/clog, recipes/cpuinfo, recipes/fp16, recipes/fxdiv, recipes/gloo, recipes/nnpack, recipes/opcodes, recipes/peachpy, recipes/psimd, recipes/pthreadpool, recipes/qnnpack, recipes/xnnpack) and found it was in an excellent condition.

@h-vetinari
Copy link
Member

Awesome work!

Let me know if something specific needs reviewing. :)

@hmaarrfk
Copy link
Contributor Author

One thing I would want to do is make the patches for the CMake changes upstreamable. I've learned that some dependencies are header only.

Those are stated as STATIC libraries, while we should only be looking for the INTERFACE. This seems like something that upstream might accept.

Finally, I think using FindPackage is likely good for shared system libraries, but I haven't had a chance to test this hypothesis.

Ultimately, this is mostly an academic exercise at this stage, since I don't know how to maintain this.
We would likely have to build these libraries statically, but they don't really move the needle in terms of compilation time for pytorch.

@hmaarrfk hmaarrfk added stale will be closed in 30 days and removed stale will be closed in 30 days labels Nov 4, 2023
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/asmjit, recipes/c10, recipes/clog, recipes/cpuinfo, recipes/dynolog, recipes/fbgemm, recipes/fp16, recipes/fxdiv, recipes/gloo, recipes/kineto, recipes/libnop, recipes/libonnx, recipes/libtorch, recipes/nnpack, recipes/onnx-tensorrt, recipes/opcodes, recipes/peachpy, recipes/pfs, recipes/psimd, recipes/pthreadpool, recipes/pytorch_qnnpack, recipes/qnnpack, recipes/tensorpipe, recipes/torch_tb_profiler, recipes/xnnpack) and found some lint.

Here's what I've got...

For recipes/torch_tb_profiler:

  • The recipe must have a build/number section.

For recipes/torch_tb_profiler:

Documentation on acceptable licenses can be found here.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/asmjit, recipes/c10, recipes/clog, recipes/cpuinfo, recipes/dynolog, recipes/fbgemm, recipes/fp16, recipes/fxdiv, recipes/gloo, recipes/kineto, recipes/libnop, recipes/libonnx, recipes/libtorch, recipes/nnpack, recipes/onnx-tensorrt, recipes/opcodes, recipes/peachpy, recipes/pfs, recipes/psimd, recipes/pthreadpool, recipes/pytorch_qnnpack, recipes/qnnpack, recipes/tensorpipe, recipes/torch_tb_profiler, recipes/xnnpack) and found some lint.

Here's what I've got...

For recipes/torch_tb_profiler:

  • The recipe must have a build/number section.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/asmjit, recipes/c10, recipes/clog, recipes/cpuinfo, recipes/dynolog, recipes/fbgemm, recipes/fp16, recipes/fxdiv, recipes/gloo, recipes/kineto, recipes/libnop, recipes/libtorch, recipes/nnpack, recipes/onnx, recipes/onnx-tensorrt, recipes/opcodes, recipes/peachpy, recipes/pfs, recipes/psimd, recipes/pthreadpool, recipes/pytorch_qnnpack, recipes/qnnpack, recipes/tensorpipe, recipes/torch_tb_profiler, recipes/xnnpack) and found some lint.

Here's what I've got...

For recipes/torch_tb_profiler:

  • The recipe must have a build/number section.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/asmjit, recipes/c10, recipes/clog, recipes/cpuinfo, recipes/dynolog, recipes/fbgemm, recipes/fp16, recipes/fxdiv, recipes/gloo, recipes/kineto, recipes/libnop, recipes/libtorch, recipes/nnpack, recipes/onnx, recipes/onnx-tensorrt, recipes/opcodes, recipes/peachpy, recipes/pfs, recipes/psimd, recipes/pthreadpool, recipes/pytorch_qnnpack, recipes/qnnpack, recipes/tensorpipe, recipes/torch_tb_profiler, recipes/xnnpack) and found it was in an excellent condition.

Copy link

stale bot commented May 4, 2024

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added the stale will be closed in 30 days label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale will be closed in 30 days
Development

Successfully merging this pull request may close these issues.

None yet

4 participants