Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add faser recipe #19195

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Add faser recipe #19195

wants to merge 7 commits into from

Conversation

goanpeca
Copy link
Member

@goanpeca goanpeca commented Jun 8, 2022

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/faser) and found some lint.

Here's what I've got...

For recipes/faser:

  • The license item is expected in the about section.
  • The summary item is expected in the about section.

@goanpeca
Copy link
Member Author

goanpeca commented Jun 8, 2022

We are in the process of creating conda packages for napari plugins and related dependencies. Once this recipe passes all the checks, every time a new release goes into PyPI, a PR will be created automatically, with usually very minor need for changes so the process of maintaining this moving forward is small. Also the @conda-forge/napari team will be available to help as needed.

You can read a bit more about conda-forge at https://conda-forge.org/#contribute


@jhnnsrs, do you agree with being added as a maintainer?

@jhnnsrs
Copy link

jhnnsrs commented Jun 9, 2022

Sure! Faser is still in quite an experimental state and we are just using it for educational purposes within our lab for now. But happy to help bringing it to conda forge !

@goanpeca
Copy link
Member Author

goanpeca commented Jun 10, 2022

Sure! Faser is still in quite an experimental state and we are just using it for educational purposes within our lab for now. But happy to help bringing it to conda forge !

Thanks @jhnnsrs. We were looking into plugins listed in the hub.

Currently the plugin does not provide a LICENSE file or a summary so, until that is included we cannot merge this PR.

@goanpeca
Copy link
Member Author

goanpeca commented Aug 4, 2022

Pinging @jhnnsrs. Any update on LICENSE and summary information?

Cheers!

1 similar comment
@goanpeca
Copy link
Member Author

Pinging @jhnnsrs. Any update on LICENSE and summary information?

Cheers!

@goanpeca
Copy link
Member Author

Pinging @jhnnsrs

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/faser) and found some lint.

Here's what I've got...

For recipes/faser:

  • The license item is expected in the about section.
  • The summary item is expected in the about section.

@jhnnsrs
Copy link

jhnnsrs commented Apr 18, 2023

Sorry for getting back so late! I will add license and readme on the github repo (and pypi) by next week, would that help? Or where should i update the about section?

@goanpeca
Copy link
Member Author

Sorry for getting back so late! I will add license and readme on the github repo (and pypi) by next week, would that help? Or where should i update the about section?

That works :)

Copy link

stale bot commented May 4, 2024

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added the stale will be closed in 30 days label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting author contribution stale will be closed in 30 days
Development

Successfully merging this pull request may close these issues.

None yet

3 participants