Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sqlalchemy-jsonapi 4.0.8 #1942

Closed
wants to merge 3 commits into from

Conversation

bollwyvl
Copy link
Contributor

This is a handy library for working with SQLAlchemy models as JSON api.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sqlalchemy-jsonapi) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/plop, recipes/pygraphviz, recipes/sqlalchemy-jsonapi, recipes/ts-loader, recipes/typescript, recipes/webpack) and found some lint.

Here's what I've got...

For recipes/ts-loader:

  • The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'requirements', 'about', 'extra'].
  • The recipe must have some tests.

For recipes/typescript:

  • The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'requirements', 'test', 'about', 'extra'].

For recipes/webpack:

  • The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'requirements', 'test', 'about', 'extra'].

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sqlalchemy-jsonapi) and found it was in an excellent condition.

@@ -1,46 +0,0 @@
{% set name = "extinction" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! I'll probably rebase to get back to something more normal!


about:
home: https://github.com/ColtonProvias/sqlalchemy-jsonapi
license: MIT
Copy link
Member

@jakirkham jakirkham Nov 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ask upstream to add a MANIFEST.in and include their LICENSE file in it via an issue and/or a PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- setuptools

run:
- enum34 # [py<34]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly conda-smithy does poorly with this type of selector ATM. Please change to py2k instead.

xref: conda-forge/conda-smithy#257

build:
number: 0
script:
- python setup.py install --single-version-externally-managed --record=record.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would recommend adding -B after python and before setup.py. This should avoid compiling dependencies and including them in the package.

xref: conda-forge/conda-forge.github.io#264

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this can be moved into a single line without a list.


package:
name: sqlalchemy-jsonapi
version: "{{ version }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for quotes.


source:
fn: "{{ name }}-{{ version }}.tgz"
url: "https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for quotes.

{% set sha256 = "3f529ea8dd707760bdf4146862f102467b376ef9b618d97d3a8e222d12bb6dc6" %}

package:
name: sqlalchemy-jsonapi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could do {{ name|lower }}.

@bollwyvl
Copy link
Contributor Author

Thanks for the great review! Will see to it when next i have a chance!

@scopatz
Copy link
Member

scopatz commented Dec 20, 2016

Any updates to this @bollwyvl?

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sqlalchemy-jsonapi) and found it was in an excellent condition.

@synapticarbors
Copy link
Member

@bollwyvl Any updates to this? I'd be happy to take a look at any new updates you push and merge it once everything checks out.

@stale
Copy link

stale bot commented Feb 14, 2020

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on master so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added the stale will be closed in 30 days label Feb 14, 2020
@stale
Copy link

stale bot commented Mar 15, 2020

Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is conda-forge. If you'd like to reopen this PR, please feel free to do so at any time!

Cheers and have a great day!

@stale stale bot closed this Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting author contribution stale will be closed in 30 days
Development

Successfully merging this pull request may close these issues.

None yet

5 participants