-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sqlalchemy-jsonapi 4.0.8 #1942
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/ts-loader:
For recipes/typescript:
For recipes/webpack:
|
949c2f8
to
e506b4e
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@@ -1,46 +0,0 @@ | |||
{% set name = "extinction" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't remove any recipes already included in staged-recipes
. This should no longer be necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok! I'll probably rebase to get back to something more normal!
|
||
about: | ||
home: https://github.com/ColtonProvias/sqlalchemy-jsonapi | ||
license: MIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ask upstream to add a MANIFEST.in
and include their LICENSE
file in it via an issue and/or a PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- setuptools | ||
|
||
run: | ||
- enum34 # [py<34] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly conda-smithy
does poorly with this type of selector ATM. Please change to py2k
instead.
build: | ||
number: 0 | ||
script: | ||
- python setup.py install --single-version-externally-managed --record=record.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would recommend adding -B
after python
and before setup.py
. This should avoid compiling dependencies and including them in the package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this can be moved into a single line without a list.
|
||
package: | ||
name: sqlalchemy-jsonapi | ||
version: "{{ version }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for quotes.
|
||
source: | ||
fn: "{{ name }}-{{ version }}.tgz" | ||
url: "https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for quotes.
{% set sha256 = "3f529ea8dd707760bdf4146862f102467b376ef9b618d97d3a8e222d12bb6dc6" %} | ||
|
||
package: | ||
name: sqlalchemy-jsonapi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could do {{ name|lower }}
.
Thanks for the great review! Will see to it when next i have a chance! |
Any updates to this @bollwyvl? |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@bollwyvl Any updates to this? I'd be happy to take a look at any new updates you push and merge it once everything checks out. |
Hi friend! We really, really, really appreciate that you have taken the time to make a PR on In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on master so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the Cheers and thank you for contributing to this community effort! |
Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is Cheers and have a great day! |
This is a handy library for working with SQLAlchemy models as JSON api.