Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ipyvizzu and ipyvizzu-story from PyPI #19838

Merged
merged 2 commits into from
Jul 28, 2022

Conversation

sugatoray
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ipyvizzu, recipes/ipyvizzu-story) and found it was in an excellent condition.

@sugatoray
Copy link
Contributor Author

Reason for Build Failure: 1/N

Observation:

👉 Module 'jsonschema' is not available in dependencies.

  • line number: 1246: (error)
  • time elapsed: 3m:51s
import jsonschema  # type: ignore
ModuleNotFoundError: No module named 'jsonschema'
Click to expand: Detailed Error Trace

import: 'ipyvizzu'
Traceback (most recent call last):
  File "/home/conda/staged-recipes/build_artifacts/ipyvizzu_1658945304505/test_tmp/run_test.py", line 2, in <module>
    import ipyvizzu
  File "/home/conda/staged-recipes/build_artifacts/ipyvizzu_1658945304505/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.10/site-packages/ipyvizzu/__init__.py", line 3, in <module>
    from .chart import Chart
  File "/home/conda/staged-recipes/build_artifacts/ipyvizzu_1658945304505/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.10/site-packages/ipyvizzu/chart.py", line 10, in <module>
    from ipyvizzu.animation import Animation, Snapshot, AnimationMerger
  File "/home/conda/staged-recipes/build_artifacts/ipyvizzu_1658945304505/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.10/site-packages/ipyvizzu/animation.py", line 8, in <module>
    import jsonschema  # type: ignore
ModuleNotFoundError: No module named 'jsonschema'
Tests failed for ipyvizzu-0.12.0-pyhd8ed1ab_0.tar.bz2 - moving package to /home/conda/staged-recipes/build_artifacts/broken
WARNING:conda_build.build:Tests failed for ipyvizzu-0.12.0-pyhd8ed1ab_0.tar.bz2 - moving package to /home/conda/staged-recipes/build_artifacts/broken
TESTS FAILED: ipyvizzu-0.12.0-pyhd8ed1ab_0.tar.bz2

- add `jsonschema`
@sugatoray
Copy link
Contributor Author

Notes

The build passes for Linux alone (fails for OSX and Windows). But that is okay as the recipe is noarch: python. Only successful linux build is sufficient.

@sugatoray
Copy link
Contributor Author

PR is ready. Request for review/merging.

cc: @conda-forge/help-python @ocefpaf @BastianZim

@ocefpaf
Copy link
Member

ocefpaf commented Jul 28, 2022

cc: @conda-forge/help-python @ocefpaf @BastianZim

You don't need to ping me or Bastian. We are already part of the python review team.

@ocefpaf
Copy link
Member

ocefpaf commented Jul 28, 2022

Notes

The build passes for Linux alone (fails for OSX and Windows). But that is okay as the recipe is noarch: python. Only successful linux build is sufficient.

Not necessarily. If it is a missing dependency on those platform we can keep noarch but if it is something that will make the package installable but unusable we cannot. Looks like Windows is the former but I'm not sure what is going on with macOS.

@sugatoray
Copy link
Contributor Author

Not necessarily. If it is a missing dependency on those platform we can keep noarch but if it is something that will make the package installable but unusable we cannot. Looks like Windows is the former but I'm not sure what is going on with macOS.

So, what would you suggest here? I am kind of out of my depth here (osx). Could you please ask someone else to also review this PR and see if they can suggest anything about what's going on with macOS?

@ocefpaf
Copy link
Member

ocefpaf commented Jul 28, 2022

Looks like a restart did the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants