Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CRAN package seAMLess #20329

Closed
wants to merge 2 commits into from
Closed

Add CRAN package seAMLess #20329

wants to merge 2 commits into from

Conversation

eonurk
Copy link

@eonurk eonurk commented Sep 6, 2022

This is my first time contributing to conda-forge, so please excuse my inexpertness.

This is the first PR for CRAN package seAMLess, I used conda_r_skeleton_helper to create this fork and followed the instructions on the maintainers' guide.

Thank you for your effort,

@conda-forge-admin, please ping team, and for the sake of completeness @conda-forge/help-r.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/team, and so here I am doing that.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/r-seamless) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/r-seamless:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/team, and so here I am doing that.

14 similar comments
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/team, and so here I am doing that.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/team, and so here I am doing that.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/team, and so here I am doing that.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/team, and so here I am doing that.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/team, and so here I am doing that.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/team, and so here I am doing that.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/team, and so here I am doing that.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/team, and so here I am doing that.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/team, and so here I am doing that.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/team, and so here I am doing that.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/team, and so here I am doing that.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/team, and so here I am doing that.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/team, and so here I am doing that.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/team, and so here I am doing that.

@eonurk
Copy link
Author

eonurk commented Sep 6, 2022

Can someone help me with this? :)

I wrote the package and published on CRAN, and since two of the libraries were not available neither in CRAN nor in bioconductor, I had to implement it via drat package, and serve those two libraries on my own github. I found one of them (r-music) on anaconda but I don't know how to add it as it is not available in conda-forge. I edited the conda-forge.yml to have the default channels as I thought that the default channels would include anaconda.

@dbast
Copy link
Member

dbast commented Sep 7, 2022

@eonurk All dependencies of a conda-forge package have to be available via conda-forge ... adding other channels (defaults, main, bioconda) to conda-forge recipes is not supported. Packages that depend on bioconda packages are better added to bioconda to avoid duplication of their dependencies on conda-forge.

@eonurk
Copy link
Author

eonurk commented Sep 7, 2022

Thank you @dbast. I see but then how about some of the dependencies are available within one channel but not in the others, and vice versa? Then, what would be the way to proceed? Simply, if I write a recipe for bioconda would I be able to depend on packages that are only available on conda-forge for instance, or such a package does not exist?

@dbast
Copy link
Member

dbast commented Sep 7, 2022

Yes, each project defines that by itself... so bioconda allows depending on conda-forge packages...

@eonurk
Copy link
Author

eonurk commented Sep 8, 2022

Thanks @dbast, closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants