Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding business duration receipe #20681

Closed
wants to merge 6 commits into from
Closed

adding business duration receipe #20681

wants to merge 6 commits into from

Conversation

frankzhu93
Copy link

@frankzhu93 frankzhu93 commented Oct 7, 2022 •
edited

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/business-duration) and found it was in an excellent condition.

@frankzhu93
Copy link
Author

@conda-forge/help-python The receipe has been passed all the checks and ready for review. Thanks.

@frankzhu93
Copy link
Author

@conda-forge/help-python The receipe has been passed all the checks and ready for review. Let me know if there is any issue need to be fixed. Thanks.

xhochy
xhochy reviewed Oct 22, 2022
View reviewed changes
Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend to regenerate this recipe with grayskull to work around some issues.

recipes/business-duration/meta.yaml
version: "{{ version }}"

source:
url: "https://files.pythonhosted.org/packages/e5/1d/12b3bb612a19d20ca2d9fe7ebfc80ab6b9e1d5d575c6a3dcd121c7cbfed4/business_duration-0.66.tar.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL should be templated with the version number.

recipes/business-duration/meta.yaml
- python >=3.6

test:
imports:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a call to pip check here

recipes/business-duration/meta.yaml
home: "https://github.com/gnaneshwar441/Business_Duration"
license: "MIT"
license_family: "MIT"
license_file: "PKG-INFO"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't sound like a typical license file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not, it's only the license metadata from packaging, no actual text with language of the license.

@stale
Copy link

stale bot commented May 3, 2023

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added the stale will be closed in 30 days label May 3, 2023
@stale
Copy link

stale bot commented Jun 2, 2023

Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is conda-forge. If you'd like to reopen this PR, please feel free to do so at any time!

Cheers and have a great day!

@stale stale bot closed this Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhochy xhochy xhochy left review comments

@dopplershift dopplershift dopplershift left review comments

Assignees
No one assigned
Labels
Awaiting author contribution python stale will be closed in 30 days
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@frankzhu93 @conda-forge-linter @xhochy @dopplershift @BastianZim