Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare recipe for xmlf90 #20733

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Prepare recipe for xmlf90 #20733

wants to merge 10 commits into from

Conversation

albgar
Copy link

@albgar albgar commented Oct 12, 2022

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes) and found some lint.

Here's what I've got...

For recipes:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/xmlf90) and found some lint.

Here's what I've got...

For recipes/xmlf90:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/xmlf90) and found some lint.

Here's what I've got...

For recipes/xmlf90:

  • Please do not delete the example recipe found in recipes/example/meta.yaml.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/xmlf90) and found it was in an excellent condition.

@albgar albgar marked this pull request as draft October 13, 2022 16:32
@albgar albgar marked this pull request as ready for review December 7, 2022 14:28
@albgar albgar changed the title WIP: Prepare recipe for xmlf90 Prepare recipe for xmlf90 Dec 7, 2022
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/xmlf90) and found it was in an excellent condition.

@zerothi
Copy link
Contributor

zerothi commented Mar 31, 2023

@conda-forge/staged-recipes this is done, would you mind a review?

Comment on lines +12 to +14
build:
number: 0
skip: true # [win]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
build:
number: 0
skip: true # [win]
build:
run_exports:
- {{ pin_subpackage('xmlf90', max_pin='x.x.x') }}
number: 0
skip: true # [win]

You package needs a run export to ensure that downstream packages depend on a version of this package with a compatible ABI. Please adjust max_pin according to the ABI guarantees of your library.

Comment on lines +22 to +25
test:
commands:
- test -f $PREFIX/lib/libxmlf90${SHLIB_EXT}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test:
commands:
- test -f $PREFIX/lib/libxmlf90${SHLIB_EXT}
test:
commands:
- test -f $PREFIX/lib/libxmlf90${SHLIB_EXT}
- test -f $PREFIX/lib/cmake/xmlf90/xmlf90-config.cmake
- test -f $PREFIX/lib/pkgconfig/xmlf90.pc
- test -f $PREFIX/include/xmlf90/GNU-12.3.0/m_sax_charset.mod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants