-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding mcpl #20740
Adding mcpl #20740
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/staged-recipes ready for review here |
${CMAKE_ARGS} | ||
|
||
make -j${CPU_COUNT:-1} | ||
make install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a make check
we can run here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately not (there are just the tests in meta.yaml for now), but I have added a comment that we should add it, if the project at some point will support it.
Co-authored-by: Filipe <ocefpaf@gmail.com>
For some unknown reason the missing line could not be autocomitted from githubs PR review page.
Thanks a lot for the review @ocefpaf! I essentially committed all of your suggested changes directly. Concerning the question about "make check", there is not currently any such functionality offered by MCPL, but I have added a comment in the build.sh file, reminding me to add it if it appears. Concerning the dependency on So I believe I have addressed all of your requested changes :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be ok now
Packaging the MCPL project which provides tools for the .mcpl format, the most widely used interchange format for particle data between Monte Carlo-based particle simulation applications (supporting 11 applications currently with a few more in the pipeline). More info: website, github, and publication.
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).