Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding mcpl #20740

Merged
merged 3 commits into from
Oct 14, 2022
Merged

Adding mcpl #20740

merged 3 commits into from
Oct 14, 2022

Conversation

tkittel
Copy link
Member

@tkittel tkittel commented Oct 13, 2022

Packaging the MCPL project which provides tools for the .mcpl format, the most widely used interchange format for particle data between Monte Carlo-based particle simulation applications (supporting 11 applications currently with a few more in the pipeline). More info: website, github, and publication.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mcpl) and found it was in an excellent condition.

@tkittel
Copy link
Member Author

tkittel commented Oct 13, 2022

@conda-forge/staged-recipes ready for review here

recipes/mcpl/meta.yaml Outdated Show resolved Hide resolved
recipes/mcpl/meta.yaml Outdated Show resolved Hide resolved
recipes/mcpl/meta.yaml Show resolved Hide resolved
recipes/mcpl/meta.yaml Outdated Show resolved Hide resolved
${CMAKE_ARGS}

make -j${CPU_COUNT:-1}
make install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a make check we can run here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately not (there are just the tests in meta.yaml for now), but I have added a comment that we should add it, if the project at some point will support it.

tkittel and others added 2 commits October 14, 2022 09:36
Co-authored-by: Filipe <ocefpaf@gmail.com>
For some unknown reason the missing line could not be autocomitted from githubs
PR review page.
@tkittel
Copy link
Member Author

tkittel commented Oct 14, 2022

Thanks a lot for the review @ocefpaf! I essentially committed all of your suggested changes directly.

Concerning the question about "make check", there is not currently any such functionality offered by MCPL, but I have added a comment in the build.sh file, reminding me to add it if it appears.

Concerning the dependency on cmake during the tests stage, it is because I am testing that find_package(MCPL) works out of the box in a conda environment (it did not work initially, so the test is useful to me to have in to guard against regressions).

So I believe I have addressed all of your requested changes :-)

Copy link
Member Author

@tkittel tkittel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok now

@ocefpaf ocefpaf merged commit 7774e1c into conda-forge:main Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants