Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add napari-svetlana recipe #21278

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

goanpeca
Copy link
Member

@goanpeca goanpeca commented Nov 24, 2022

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

  • nothing provides requested cucim >=22.6.0
  • nothing provides requested cupy-cuda102 >=10.6.0
  • nothing provides requested light-the-torch

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/napari-svetlana) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/napari-svetlana:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@goanpeca
Copy link
Member Author

We are in the process of creating conda packages for napari plugins and related dependencies. Once this recipe passes all the checks, every time a new release goes into PyPI, a PR will be created automatically, with usually very minor need for changes so the process of maintaining this moving forward is small. Also the @conda-forge/napari team will be available to help as needed.

You can read a bit more about conda-forge at https://conda-forge.org/#contribute


@jaimergp, @koopa31 do you agree with being added as maintainers?

@goanpeca
Copy link
Member Author

goanpeca commented Nov 24, 2022

@koopa31, question: is the license GPL-3.0 or later or GPL-3.0 only?

Also

    - albumentations ==1.0.3
    - cucim ==22.6.0  # [linux]
    - cupy-cuda102 ==10.6.0
    - joblib ==1.1.0
    - opencv ==4.5.5.62

Is there a reason for these dependencies to be exact pinnings? Can they be relaxed?

Thanks!

@goanpeca
Copy link
Member Author

Pinging @koopa31

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/napari-svetlana) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/napari-svetlana:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/napari-svetlana) and found some lint.

Here's what I've got...

For recipes/napari-svetlana:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

For recipes/napari-svetlana:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/napari-svetlana) and found it was in an excellent condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants