Aimrocks

[hadim]

Checklist

• Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
• License file is packaged (see here for an example).
• Source is from official source.
• Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
• If static libraries are linked in, the license of the static library is packaged.
• Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
• Build number is 0.
• A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
• GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
• When in trouble, please check our knowledge base documentation before pinging a team.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/aimrocks) and found it was in an excellent condition.

[hadim]

Blocked by the missing rocksdb 6.29.5 on conda-forge: conda-forge/rocksdb-feedstock#48

[hadim]

@gorarakelyan now that rocksdb 6.29.5 is available, I can continue on this one. For now, I have hard-coded the git hash matching aimrocks==0.2.1 but before merging here we need to get a git tag from aimrocks. Is that something you could do?

Also do you want to be added as a maintainer of the package?

[hadim]

@conda-forge/help-python-c ready for review

[hadim]

correlated package: #21651

[gorarakelyan]

@hadim I just pushed v0.2.1 tag for aimrocks. Yes, if it is possible please add me as a maintainer for both aimrocks and aim-ui.

[hadim]

@gorarakelyan: I noticed the rocksdb .so file is embedded into the package which is not a good practice when packaging on conda forge since the rocksdb lib is now a direct dep of the aimrocks package.

I have a made small patch to the setup.py file of aimrocks to be able to control whether one wants to embed rocksdb or not. The default behaviour remains the same as before, so you could eventually backport this patch upstream if you want for your next release.

You can check the patch at 08fb6d9

[hadim]

LGTM

[hadim]

@beckermr sorry to poke you here but would you have some time to review this PR alongside this one as well #21651?

That would be very helpful!

[hadim]

Thanks @beckermr!