Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ditaa-v0.11.0 #21854

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

ajaypnair09
Copy link

@ajaypnair09 ajaypnair09 commented Jan 25, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ditaa) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/ditaa:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ditaa) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ditaa) and found some lint.

Here's what I've got...

For recipes/ditaa:

  • license_file entry is missing, but is required.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ditaa) and found it was in an excellent condition.

@ajaypnair09
Copy link
Author

@conda-forge/help-java can you please review and merge if it's ok?

recipes/ditaa/meta.yaml Outdated Show resolved Hide resolved
recipes/ditaa/meta.yaml Outdated Show resolved Hide resolved
recipes/ditaa/meta.yaml Outdated Show resolved Hide resolved
home: https://github.com/stathissideris/ditaa
license: LGPL-3.0-only
license_family: LGPL
license_file: LICENSE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For java files, you should also list all third-party notices. This probably works better if you build the JAR from source.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Now jar file is created from source.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still need to list all licenses in a Notice file.

recipes/ditaa/build.sh Outdated Show resolved Hide resolved
recipes/ditaa/build.sh Outdated Show resolved Hide resolved
@ajaypnair09 ajaypnair09 force-pushed the Add-ditaa-v0.11.0 branch 5 times, most recently from e58dbcc to eb002a8 Compare February 13, 2023 08:21
@ajaypnair09
Copy link
Author

@conda-forge/help-java, @xhochy can you please review and merge if it's ok?

@ajaypnair09
Copy link
Author

@conda-forge/staged-recipes Could you please review and merge if the PR is OK

@ajaypnair09
Copy link
Author

@conda-forge/staged-recipes Could you please review and help me to proceed further

@ajaypnair09
Copy link
Author

Hello @xhochy , @conda-forge/staged-recipes , This is just a reminder. Kindly review the PR and help me to merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants