-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ditaa-v0.11.0 #21854
base: main
Are you sure you want to change the base?
Add ditaa-v0.11.0 #21854
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/ditaa:
Documentation on acceptable licenses can be found here. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
47ee260
to
6a2233c
Compare
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/ditaa:
|
6a2233c
to
4c9fd06
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
4c9fd06
to
8e130a1
Compare
8e130a1
to
8cf6ef9
Compare
@conda-forge/help-java can you please review and merge if it's ok? |
home: https://github.com/stathissideris/ditaa | ||
license: LGPL-3.0-only | ||
license_family: LGPL | ||
license_file: LICENSE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For java files, you should also list all third-party notices. This probably works better if you build the JAR from source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. Now jar file is created from source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You still need to list all licenses in a Notice file.
e58dbcc
to
eb002a8
Compare
eb002a8
to
44d1ad9
Compare
@conda-forge/help-java, @xhochy can you please review and merge if it's ok? |
@conda-forge/staged-recipes Could you please review and merge if the PR is OK |
@conda-forge/staged-recipes Could you please review and help me to proceed further |
Hello @xhochy , @conda-forge/staged-recipes , This is just a reminder. Kindly review the PR and help me to merge it |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).