Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heat #21933

Closed
wants to merge 3 commits into from
Closed

Add heat #21933

wants to merge 3 commits into from

Conversation

swaptr
Copy link

@swaptr swaptr commented Feb 2, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@swaptr swaptr marked this pull request as ready for review February 2, 2023 04:37
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/heat) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/heat) and found some lint.

Here's what I've got...

For recipes/heat:

  • requirements: run: h5py >= 2.8.0 should not contain a space between relational operator and the version, i.e. h5py >=2.8.0
  • requirements: run: netCDF4 >= 1.5.6 should not contain a space between relational operator and the version, i.e. netCDF4 >=1.5.6
  • requirements: run: docutils >= 0.16 should not contain a space between relational operator and the version, i.e. docutils >=0.16
  • requirements: run: pre-commit >= 1.18.3 should not contain a space between relational operator and the version, i.e. pre-commit >=1.18.3
  • requirements: run: scikit-learn >= 0.24.0 should not contain a space between relational operator and the version, i.e. scikit-learn >=0.24.0
  • requirements: run: matplotlib >= 3.1.0 should not contain a space between relational operator and the version, i.e. matplotlib >=3.1.0
  • requirements: run: docutils >= 0.16 should not contain a space between relational operator and the version, i.e. docutils >=0.16

For recipes/heat:

  • Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/heat) and found it was in an excellent condition.

Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @swaptr !

I proposed some changes. We probably need to specify preferred channels? I.e. -c pytorch for torch and torchvision, conda-forge for everything else.

Thanks!

recipes/heat/meta.yaml Show resolved Hide resolved
recipes/heat/meta.yaml Outdated Show resolved Hide resolved
recipes/heat/meta.yaml Outdated Show resolved Hide resolved
recipes/heat/meta.yaml Outdated Show resolved Hide resolved
@swaptr swaptr force-pushed the heat branch 2 times, most recently from f3cd554 to f67a2d7 Compare February 4, 2023 15:57
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/heat) and found some lint.

Here's what I've got...

For recipes/heat:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/heat) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/heat) and found some lint.

Here's what I've got...

For recipes/heat:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/heat) and found some lint.

Here's what I've got...

For recipes/heat:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [22, 23, 38, 39, 40]
  • There are too few lines. There should be one empty line at the end of the file.
  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/heat) and found some lint.

Here's what I've got...

For recipes/heat:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/heat) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/heat) and found some lint.

Here's what I've got...

For recipes/heat:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [12]

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/heat) and found it was in an excellent condition.

@stale
Copy link

stale bot commented Jul 11, 2023

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added the stale will be closed in 30 days label Jul 11, 2023
@ClaudiaComito
Copy link
Contributor

Needs update after Heat 1.3. release. @swaptr sorry for taking so long to finalize this. I'm not able to edit the recipe myself.

@stale stale bot removed the stale will be closed in 30 days label Jul 24, 2023
Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need two small changes to reflect the latest release @swaptr . Thanks for your work, very much appreciated! 🙏🏼

recipes/heat/meta.yaml Outdated Show resolved Hide resolved
recipes/heat/meta.yaml Outdated Show resolved Hide resolved
Co-authored-by: Claudia Comito <39374113+ClaudiaComito@users.noreply.github.com>
Copy link

stale bot commented Jan 11, 2024

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added the stale will be closed in 30 days label Jan 11, 2024
Copy link

stale bot commented Feb 10, 2024

Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is conda-forge. If you'd like to reopen this PR, please feel free to do so at any time!

Cheers and have a great day!

@stale stale bot closed this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale will be closed in 30 days
Development

Successfully merging this pull request may close these issues.

None yet

2 participants