Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gnome-icon-theme #22077

Closed
wants to merge 32 commits into from
Closed

Conversation

Tobias-Fischer
Copy link
Contributor

@Tobias-Fischer Tobias-Fischer commented Feb 19, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/gnome-icon-theme) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/gnome-icon-theme, recipes/icon-naming-utils) and found some lint.

Here's what I've got...

For recipes/icon-naming-utils:

  • The recipe must have some tests.

For recipes/icon-naming-utils:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/gnome-icon-theme, recipes/icon-naming-utils, recipes/perl-xml-simple) and found some lint.

Here's what I've got...

For recipes/icon-naming-utils:

  • The recipe must have some tests.

For recipes/icon-naming-utils:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

For recipes/perl-xml-simple:

  • The recipe could do with some maintainers listed in the extra/recipe-maintainers section.

For recipes/perl-xml-simple:

  • Recipe with the same name exists in bioconda: please discuss with @conda-forge/bioconda-recipes.
  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/gnome-icon-theme, recipes/icon-naming-utils, recipes/perl-xml-simple) and found some lint.

Here's what I've got...

For recipes/icon-naming-utils:

  • The recipe must have some tests.

For recipes/icon-naming-utils:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

For recipes/perl-xml-simple:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

For recipes/perl-xml-simple:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/gnome-icon-theme, recipes/icon-naming-utils, recipes/perl-xml-simple) and found some lint.

Here's what I've got...

For recipes/icon-naming-utils:

  • The recipe must have some tests.

For recipes/icon-naming-utils:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

For recipes/perl-xml-simple:

  • license_file entry is missing, but is required.

For recipes/perl-xml-simple:

  • Recipe with the same name exists in bioconda: please discuss with @conda-forge/bioconda-recipes.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/gnome-icon-theme, recipes/icon-naming-utils, recipes/perl-xml-simple) and found some lint.

Here's what I've got...

For recipes/icon-naming-utils:

  • The recipe must have some tests.

For recipes/icon-naming-utils:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

For recipes/perl-xml-simple:

  • Recipe with the same name exists in bioconda: please discuss with @conda-forge/bioconda-recipes.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/gnome-icon-theme, recipes/icon-naming-utils, recipes/perl-xml-simple) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/perl-xml-simple:

  • Recipe with the same name exists in bioconda: please discuss with @conda-forge/bioconda-recipes.

@Tobias-Fischer
Copy link
Contributor Author

In theory, this is ready to be merged, but I am not sure if we want/need this - see RoboStack/ros-noetic#225

What do you think @hmaarrfk - is there any use in any of the added packages?

@hmaarrfk
Copy link
Contributor

I haven't found a use yet. Maybe you want to cross reference this in the GTK feedstock for visibility and just let it sit here until you need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants