Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cuda-nvml-dev recipe #22127

Merged
merged 9 commits into from
Apr 18, 2023
Merged

Add cuda-nvml-dev recipe #22127

merged 9 commits into from
Apr 18, 2023

Conversation

adibbley
Copy link
Contributor

@adibbley adibbley commented Feb 23, 2023 •
edited
Loading

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cuda-nvml-dev) and found it was in an excellent condition.

@adibbley
Copy link
Contributor Author

cc @jakirkham

@adibbley adibbley mentioned this pull request Feb 23, 2023
Closed
49 tasks
@jakirkham jakirkham mentioned this pull request Feb 23, 2023
Open
adibbley and others added 3 commits March 22, 2023 09:08
@adibbley @bdice
Apply suggestions from code review
6bbecf4 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@jakirkham
Merge branch 'main' into cuda-nvml-dev
f39cb34
@adibbley
Adding arm-variant and target_name
fc4cb92 
Update build.sh to align with other components
@jakirkham jakirkham requested a review from bdice April 6, 2023 08:42
bdice
bdice reviewed Apr 6, 2023
View reviewed changes
recipes/cuda-nvml-dev/meta.yaml

test:
commands:
- test -f $PREFIX/targets/{{ target_name }}/lib/stubs/libnvidia-ml.so # [linux]
Copy link
Contributor

@bdice bdice Apr 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the non-stub library shipped? (Another package?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a driver file, which we have no conda package for
nvidia_driver-linux-x86_64-525.85.12-archive/lib/libnvidia-ml.so.525.85.12

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Maybe a comment could help explain that? I wasn't aware.

bdice
bdice approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from the unresolved question about where to ship nvml/example/.

robertmaynard
robertmaynard approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving presuming outstanding issues are resovled.

@adibbley adibbley marked this pull request as ready for review April 12, 2023 22:12
@vyasr
Copy link
Contributor

vyasr commented Apr 13, 2023

Once the PR is merged can we open an issue on the feedstock to track the packaging of the examples?

bdice
bdice approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, aside from one small question about sysroot.

recipes/cuda-nvml-dev/meta.yaml Show resolved Hide resolved
@bdice bdice mentioned this pull request Apr 14, 2023
Merged
10 tasks
@jakirkham jakirkham requested a review from kkraus14 April 15, 2023 00:22
kkraus14
kkraus14 reviewed Apr 15, 2023
View reviewed changes
recipes/cuda-nvml-dev/meta.yaml
test:
commands:
- test -f $PREFIX/targets/{{ target_name }}/lib/stubs/libnvidia-ml.so # [linux]
- test -f $PREFIX/targets/{{ target_name }}/include/nvml.h # [linux]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this land in $PREFIX/include as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We held off on putting symlinks in $PREFIX/include for all packages. IIRC there were concerns with the generic naming of headers, such as math_functions.h and others. Using nvcc will include the targets directory by default.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. I think we should prioritize a strategy around this because most of these are host functions where nvcc isn't required and generally shouldn't be used if there's no kernels / device code.

recipes/cuda-nvml-dev/meta.yaml Show resolved Hide resolved
@kkraus14 kkraus14 mentioned this pull request Apr 17, 2023
Merged
10 tasks
@adibbley adibbley mentioned this pull request Apr 17, 2023
Closed
1 task
@jakirkham jakirkham merged commit 06a8f66 into conda-forge:main Apr 18, 2023
@jakirkham
Copy link
Member

Thanks all! 🙏

Let's follow up on anything else in the feedstock 🙂

@vyasr vyasr mentioned this pull request Apr 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard approved these changes

@jakirkham jakirkham jakirkham left review comments

@bdice bdice bdice approved these changes

@vyasr vyasr vyasr approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@adibbley @vyasr @jakirkham @robertmaynard @kkraus14 @bdice