Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HiPACE++ #22171

Merged
merged 40 commits into from
Jul 27, 2023
Merged

Add HiPACE++ #22171

merged 40 commits into from
Jul 27, 2023

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Feb 28, 2023

Add HiPACE++: Highly efficient Plasma Accelerator Emulation, quasistatic particle-in-cell code.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. AMReX is pulled on the fly, under the same license. Many binary variants make separating them very hard for now. They use the same license and the same LBNL/UC copyright holder.
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/hipace) and found some lint.

Here's what I've got...

For recipes/hipace:

  • There are 1 too many lines. There should be one empty line at the end of the file.

Add HiPACE++:
Highly efficient Plasma Accelerator Emulation, quasistatic
particle-in-cell code.
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/hipace) and found it was in an excellent condition.

recipes/hipace/meta.yaml Outdated Show resolved Hide resolved
recipes/hipace/meta.yaml Outdated Show resolved Hide resolved
recipes/hipace/bld.bat Outdated Show resolved Hide resolved
recipes/hipace/build.sh Outdated Show resolved Hide resolved
recipes/hipace/meta.yaml Outdated Show resolved Hide resolved
@ax3l ax3l mentioned this pull request Mar 1, 2023
10 tasks
recipes/hipace/meta.yaml Outdated Show resolved Hide resolved
recipes/hipace/meta.yaml Outdated Show resolved Hide resolved
@ax3l
Copy link
Member Author

ax3l commented May 4, 2023

@conda-forge/help-c-cpp I am a bit puzzled what I can do to overcome this dependent version resolution issue here.

recipes/hipace/meta.yaml Outdated Show resolved Hide resolved
recipes/hipace/meta.yaml Outdated Show resolved Hide resolved
@ax3l
Copy link
Member Author

ax3l commented Jun 3, 2023

Thank you for the guidance! Oh, that is interesting because I pull it via openPMD-api, which is in host. Do I need to list transitive dependencies from other libraries in host?

recipes/hipace/build.sh Outdated Show resolved Hide resolved
recipes/hipace/build.sh Outdated Show resolved Hide resolved
@carterbox
Copy link
Member

carterbox commented Jun 3, 2023

Thank you for the guidance! Oh, that is interesting because I pull it via openPMD-api, which is in host. Do I need to list transitive dependencies from other libraries in host?

If hipace doesn't link directly to adios2, then it should not be listed in the hipace recipe. Why do you export a dependency on adios2 from the openpmd pacakage? It is very unusual for openpmd to export a dependency on a package which is not built by the openpmd-feedstock.

@ax3l
Copy link
Member Author

ax3l commented Jun 5, 2023

Thank you for catching that. Fixed via conda-forge/openpmd-api-feedstock#104

ax3l added 2 commits June 5, 2023 11:14
Just confuses the resolver and we get the latest CMake anyway.
@ax3l ax3l requested a review from carterbox June 5, 2023 18:56
@ax3l
Copy link
Member Author

ax3l commented Jun 5, 2023

@conda-forge/help-c-cpp ready for merge :)

@carterbox
Copy link
Member

There is a package collision between adios and adios2. Open an issue on one of those feedstocks and we can discuss the details. i.e. Should aido and adios2 be mutually exclusive? If so how to accomplish that, etc.

@ax3l
Copy link
Member Author

ax3l commented Jun 5, 2023

They are complementary and can be used at the same time (e.g., in openPMD-api).

There seems to be a collision in created cli tools, where in case of conflict the tools of ADIOS2 should be selected.

@ax3l
Copy link
Member Author

ax3l commented Jun 5, 2023

Open an issue on one of those feedstocks and we can discuss the details.

Thank you 🙏
conda-forge/adios2-feedstock#72

@ax3l
Copy link
Member Author

ax3l commented Jul 27, 2023

@conda-forge/help-c-cpp ready for merge :)

@ax3l
Copy link
Member Author

ax3l commented Jul 27, 2023

@carterbox thank you for your help, all green now :)

@carterbox carterbox merged commit dec7078 into conda-forge:main Jul 27, 2023
5 checks passed
@ax3l ax3l deleted the add-hipace branch October 11, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

5 participants