Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add xkcd-cli #22395

Merged
merged 2 commits into from
Apr 10, 2023
Merged

add xkcd-cli #22395

merged 2 commits into from
Apr 10, 2023

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Mar 27, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/xkcd-cli) and found some lint.

Here's what I've got...

For recipes/xkcd-cli:

  • The home item is expected in the about section.
  • The summary item is expected in the about section.

@ocefpaf
Copy link
Member Author

ocefpaf commented Mar 27, 2023

I need this for... reasons.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/xkcd-cli) and found it was in an excellent condition.

@ocefpaf
Copy link
Member Author

ocefpaf commented Mar 28, 2023

@conda-forge/staged-recipes, ready for review

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Filipe! 🙏

Generally LGTM. Had one question below


about:
license: MIT
license_file: LICENSE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should be packaged in the future. Asked about a new release here ( dotcs/xkcd-cli#6 )

Nothing to do here. Just noting for awareness

version: {{ version }}

source:
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/xkcd-cli-{{ version }}.tar.gz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to inline name everywhere or use the Jinja variable?

No strong feelings either way. Just wanted to ask given we seem to be doing both

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitted a PR ( conda/grayskull#460 ) to Grayskull

@ocefpaf ocefpaf requested a review from jakirkham April 10, 2023 17:56
@jakirkham
Copy link
Member

Hey Filipe, saw you requested another review. Were there changes or comments on the questions above? If so, they seem not to be showing up for me. Just wanted to make sure I understand what we want to do here

@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 10, 2023

Hey Filipe, saw you requested another review. Were there changes or comments on the questions above? If so, they seem not to be showing up for me. Just wanted to make sure I understand what we want to do here

Probably clicked there by mistake. No changes, I used grayskull here and I plan to keep using it to update the recipe afterwards, so changing this will only get clobbered later in the feedstock.

@jakirkham
Copy link
Member

All good. Just want to make sure I'm not missing something

Ok let's merge then. Can raise an issue with Grayskull

@jakirkham jakirkham merged commit 4b12d5f into conda-forge:main Apr 10, 2023
@jakirkham
Copy link
Member

Thanks Filipe! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants